Skip to content
This repository has been archived by the owner on Apr 16, 2021. It is now read-only.

Explain that postdated posts can't be previewed #301

Merged
merged 3 commits into from
Sep 16, 2019

Conversation

terichadbourne
Copy link
Contributor

Clarify in the readme that setting a post's date for the future will cause it to not be displayed and prevent previewing your work.

@momack2
Copy link
Contributor

momack2 commented Sep 13, 2019

Is there a special way to "preview" the site that isn't what everyone else would see? I agree with the clarification (this got me in the past), just want to make sure the language is clear - right now this implies to me that if I were to date my post in the past, there'd be some sneaky way for me to view it without it also being visible to all other blog viewers / RSS users - which I believe isn't the case (as soon as it launches it's out there)? I think removing the lines about "previewing" would avoid this confusion for me (while keeping the lines about how the dates control publication).

@terichadbourne
Copy link
Contributor Author

@momack2 The thing I'm referring to as "previewing" is loading the site on localhost to proof your work, as described in the readme instructions. So the "sneaky way to view it without it being visible to all other blog viewers" is just to load it up locally before merging the PR, but this doesn't work in the standard flow of events where you'd be trying to write before the publication date. Is there a word other than "preview" that would make more sense to me there?

I don't think we should state that you can load it on localhost without also mentioning in the same spot that you'll fail to see it if you're prepping your article in advance and setting the publication date to the date you actually want.

Copy link
Contributor

@olizilla olizilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The specific notes here are correct. hugo will not build out the html for the blog post page nor add an item for it in the blog index if the post has a data that is in the future at the time, according to the computer it is run on.

So looking at it locally in dev mode, or looking at the published preview on ipfs via our CI build would both be affected.

@momack2
Copy link
Contributor

momack2 commented Sep 16, 2019 via email

@terichadbourne
Copy link
Contributor Author

Just to clarify, @olizilla, how would one go about finding the link to the Cl preview on IPFS? I assume it's related to this check but I don't see a preview button (not sure if that's a permissions thing). If it is possible for someone to view a preview without using the command line, it would be lovely, because it would allow for non-coders to submit a markdown file right inside GitHub and still have a chance to proof their work, but if that's an option I don't think we've made it obvious.

@terichadbourne
Copy link
Contributor Author

@momack2 I've added a couple of words to help clarify what I mean by previewing (note that the first mention is inside of a section about using localhost). Please let me know if this addresses your concerns.

I spoke with @olizilla and the Circle CI process that creates preview website on IPFS (better for those who don't want to use the command line) is only available to specific users. It's related to https://github.com/ipfs-shipyard/ipfs-dns-deploy#what-it-does and would produce a "website added to IPFS" line in the checks where some folks would be able to click for a preview.
image

I'm only addressing the localhost case in this PR since the other option isn't yet explained and will need more explanation around for whom it's an option.

This is ready to merge if you're okay with the rewording @momack2.

@terichadbourne terichadbourne merged commit 8552f0b into master Sep 16, 2019
@terichadbourne terichadbourne deleted the terichadbourne-patch-1 branch September 16, 2019 19:01
@parkan parkan mentioned this pull request Sep 19, 2019
1 task
@parkan
Copy link
Contributor

parkan commented Sep 19, 2019

looks like there's a simple option to hugo that will show the future posts, enabled it for dev mode in a PR here: #304

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants