Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GOVETFLAGS #1

Closed
Stebalien opened this issue Nov 17, 2017 · 7 comments
Closed

Add GOVETFLAGS #1

Stebalien opened this issue Nov 17, 2017 · 7 comments

Comments

@Stebalien
Copy link
Member

In some cases, we're not going to be able to fix all go vet errors and may need to disable some checks. Ideally, we'd just be able to silence specific issues but, we'll, we're dealing with the go devs here.

@Kubuxu
Copy link
Member

Kubuxu commented Nov 17, 2017

I still think we should use codeclimate for govet as it allows tracking specific issues (including ignoring them).

@kevina
Copy link
Contributor

kevina commented Nov 17, 2017

@Kubuxu what do I (or you) need to do to set up codeclimate?

@kevina
Copy link
Contributor

kevina commented Nov 20, 2017

@Kubuxu @Stebalien did you come to any sort of consistence on IRC?

We should resolve this issue before merging the Travis CI p.r. in case we need to somehow update the .travis.yml for this to work.

@Kubuxu
Copy link
Member

Kubuxu commented Nov 21, 2017

Let's skip codeclimate.

@kevina
Copy link
Contributor

kevina commented Nov 21, 2017

Okay do we want to use GOVETFLAGS to add optional flags (see https://golang.org/cmd/vet/) or make it GOVETCMD which can include flags but also be used to disable vo-vet altogether by assigning it to true. If we go with GOVETCMD than an undefined value will default to go vet.

@Kubuxu
Copy link
Member

Kubuxu commented Nov 21, 2017

SGWM.

@kevina
Copy link
Contributor

kevina commented Nov 22, 2017

GOVETCMD is now supported.

@kevina kevina closed this as completed Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants