Skip to content
This repository has been archived by the owner on Mar 22, 2022. It is now read-only.

HTTP Error 404 for /favicon.ico #35

Closed
lidel opened this issue Jun 21, 2020 · 1 comment · Fixed by #36
Closed

HTTP Error 404 for /favicon.ico #35

lidel opened this issue Jun 21, 2020 · 1 comment · Fixed by #36
Labels
dif/trivial Can be confidently tackled by newcomers effort/hours Estimated to take one or several hours good first issue Good issue for new contributors help wanted Seeking public contribution on this issue need/analysis Needs further analysis before proceeding P2 Medium: Good to have, but can wait until someone steps up

Comments

@lidel
Copy link
Member

lidel commented Jun 21, 2020

Directory listings are missing favicon definition, which makes browser to make request for implicit /favicon.ico which always fails.

To illustrate, opening https://bafybeiccfclkdtucu6y4yc5cpr6y3yuinr67svmii46v5cfcrkp47ihehy.ipfs.dweb.link/ produces two requests:

2020-06-21--22-11-52

We could either add a favicon (would have to be inlined as dataurl to work in every context) or supress the request with:

<link rel="shortcut icon"type="image/x-icon" href="data:image/x-icon;,">
@lidel lidel added help wanted Seeking public contribution on this issue P2 Medium: Good to have, but can wait until someone steps up good first issue Good issue for new contributors need/analysis Needs further analysis before proceeding dif/trivial Can be confidently tackled by newcomers effort/hours Estimated to take one or several hours labels Jun 21, 2020
@jessicaschilling jessicaschilling mentioned this issue Jun 22, 2020
Merged
@jessicaschilling
Copy link
Contributor

#36 should close this. Out for review.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
dif/trivial Can be confidently tackled by newcomers effort/hours Estimated to take one or several hours good first issue Good issue for new contributors help wanted Seeking public contribution on this issue need/analysis Needs further analysis before proceeding P2 Medium: Good to have, but can wait until someone steps up
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add base64 favicon and social sharing meta tags ipfs/dir-index-html
2 participants
@lidel @jessicaschilling