Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps!: upgrade deps, replace eslint-config-standard-with-typescript with eslint-config-love #218

Merged
merged 5 commits into from
May 1, 2024
Merged

deps!: upgrade deps, replace eslint-config-standard-with-typescript with eslint-config-love #218

merged 5 commits into from
May 1, 2024

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Apr 3, 2024 •
edited by achingbrain
Loading

Fixes #217

BREAKING CHANGE: eslint-config-love requires updated peer dependencies

@SgtPooki SgtPooki mentioned this pull request Apr 3, 2024
Closed
@SgtPooki
Copy link
Member Author

SgtPooki commented Apr 3, 2024

this is failing due to using aegir, which is broken because of eslint-config-standard. we should probably not be linting this package with 'aegir lint` to reduce the cyclic dependency

@SgtPooki SgtPooki self-assigned this Apr 3, 2024
@SgtPooki SgtPooki mentioned this pull request Apr 23, 2024
Open
@achingbrain achingbrain changed the title deps: upgrade deps deps!: upgrade deps May 1, 2024
@achingbrain
Copy link
Member

Switched to a breaking change because eslint-config-love has peer deps that are incompatible with eslint-config-standard-with-typescript so we need to upgrade them together.

@achingbrain achingbrain changed the title deps!: upgrade deps deps!: upgrade deps, replace eslint-config-standard-with-typescript with eslint-config-love May 1, 2024
@achingbrain achingbrain merged commit a83be5b into main May 1, 2024
17 checks passed
@achingbrain achingbrain deleted the deps/upgrade-deps branch May 1, 2024 11:22
github-actions bot pushed a commit that referenced this pull request May 1, 2024
@semantic-release-bot
chore(release): 7.0.0 [skip ci]
5f9ec52 
## [7.0.0](v6.0.2...v7.0.0) (2024-05-01)

### ⚠ BREAKING CHANGES

* eslint-config-love requires updated peer dependencies

### Dependencies

* upgrade deps, replace eslint-config-standard-with-typescript with eslint-config-love ([#218](#218)) ([a83be5b](a83be5b)), closes [#217](#217)
@github-actions GitHub Actions
Copy link

github-actions bot commented May 1, 2024

🎉 This PR is included in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achingbrain achingbrain Awaiting requested review from achingbrain

Assignees

@SgtPooki SgtPooki

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: config rule is preventing upgrade of @typescript-eslint/eslint-plugin from 5.62.0 to 7.5.0
2 participants
@SgtPooki @achingbrain