Skip to content
This repository has been archived by the owner on Feb 1, 2023. It is now read-only.

Memory leak in the latency tracker. #162

Closed
Stebalien opened this issue Jul 29, 2019 · 2 comments
Closed

Memory leak in the latency tracker. #162

Stebalien opened this issue Jul 29, 2019 · 2 comments

Comments

@Stebalien
Copy link
Member

No requests are running but we appear to be leaking a bunch of these.

leak.zip

@dirkmc
Copy link
Contributor

dirkmc commented Jul 30, 2019

Possible cause: It looks like we start recording latency when RecordPeerRequests() is called and we remove the request when we receive

But if we receive a peerTimeoutMessage after the want was cancelled it looks like we don't call recordResponse() so peerData.AdjustLatency() doesn't get called and the latency request tracker doesn't get cleaned up.

@dirkmc
Copy link
Contributor

dirkmc commented Jul 31, 2019

@Stebalien could you please give repro steps to produce the memory leak profile so I can make sure it's fixing the same issue you saw?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants