Skip to content
This repository has been archived by the owner on Feb 1, 2023. It is now read-only.

Wantlist Leak #310

Closed
Stebalien opened this issue Mar 20, 2020 · 5 comments
Closed

Wantlist Leak #310

Stebalien opened this issue Mar 20, 2020 · 5 comments
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@Stebalien
Copy link
Member

wantlist-leak
@Stebalien Stebalien added the kind/bug A bug in existing code (including security flaws) label Mar 20, 2020
@Stebalien
Copy link
Member Author

It looks like we're not properly canceling wants and/or sessions in some cases.

@Stebalien
Copy link
Member Author

Ok, stack parses indicate that we're not leaking goroutines. Something else is happening.

This was referenced Mar 24, 2020
Closed
Closed
@dirkmc dirkmc mentioned this issue Mar 24, 2020
Merged
@Stebalien
Copy link
Member Author

wantlist-leak2

@dirkmc dirkmc mentioned this issue Mar 30, 2020
Closed
@dirkmc
Copy link
Contributor

dirkmc commented Apr 3, 2020

Possible fix: #332

@Stebalien
Copy link
Member Author

Confirmed fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dirkmc @Stebalien