Skip to content
This repository has been archived by the owner on Feb 7, 2024. It is now read-only.

New IPFS Client Maintainers Group #141

Open
mikeal opened this issue Nov 21, 2018 · 1 comment
Open

New IPFS Client Maintainers Group #141

mikeal opened this issue Nov 21, 2018 · 1 comment

Comments

@mikeal
Copy link

mikeal commented Nov 21, 2018

Hiya :)

In the IPFS org we’ve created a new group for maintainers of client libraries. This will make it easier for us to loop you into issues that may cause problems or necessitate changes in your client library.

If you could let us know the github usernames of all the active maintainers we can add them to the group and note them in the clients table.

Also, we have a great IPFS weekly newsletter. A few days before each edition goes out a new pull request is created in the repo. If you have any announcements related to your client library feed free to log a new issue in the repo or just comment on an upcoming newsletter pull request.

@rfielding
Copy link

rfielding commented Nov 26, 2018

When I use dep ensure, I get references to leb.io that keeps my builds from working. This is due to stuff in github.com/gxed/hashland, where internally, there are references to the downed site "import leb.io/hashland/...".

I was working around the problem by copying a tarball of a vendor dir that actually pulled leb.io before it went down. It's only now that I realized that it's due to this IPFS client dependency.

For now, I am going to just pull IPFS support (using this client). That fixes my build workaround issue. Also, with range requesting broken, I wasn't able to properly use this anyway. (ie: I write out ciphertexts into IPFS, and for S3 I can range-request huge blobs... need to do the same for IPFS if I am to make any use of it at all.)

Perhaps those refs to leb.io can be fixed to point into github for the latest versions?

reproduce:

cd $project_that_uses_ipfs_client_lib
rm -rf vendor
dep ensure  # cannot find leb.io and fails

Most projects are standardizing around dep for builds. If you have an import like "import leb.io/hashland/keccak", it's going to die if it can't reach leb.io. You can ping the address, but it's not clear that a service is running there.

Example:

https://github.com/gxed/hashland/blob/master/hashf/hashf.go

Though, if I make a completely clean repo in it, and just import tests/main.go (from here) into it, the code builds. But if dep sees imports like that, it's going to fail because leb.io=. (I can ping it though).

@momack2 momack2 added this to Inbox in ipfs/go-ipfs May 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

2 participants