Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strange api failure #1620

Closed
whyrusleeping opened this issue Aug 28, 2015 · 4 comments
Closed

strange api failure #1620

whyrusleeping opened this issue Aug 28, 2015 · 4 comments
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@whyrusleeping
Copy link
Member

something strange appears to have regressed:

whyrusleeping@idril ~> ipfs add bigfile2
added Qmd1usDGx7zDU5zq3M4WQft6ENVQJtzc8XNYy4qzPEgKWE bigfile2
whyrusleeping@idril ~> cat bigfile2 | shasum
5ab871067c871695e1d7f99548f451aed6726e9f  -
whyrusleeping@idril ~> ipfs cat Qmd1usDGx7zDU5zq3M4WQft6ENVQJtzc8XNYy4qzPEgKWE | shasum
Error: read tcp 127.0.0.1:58756->127.0.0.1:5001: read: connection reset by peer
e788ad60376eab9962dbaeac0240dcd87c83c4b6  -

bigfile2 is exactly 100MB, random data from /dev/urandom
@whyrusleeping whyrusleeping added the kind/bug A bug in existing code (including security flaws) label Aug 28, 2015
@whyrusleeping
Copy link
Member Author

failing commit:

a7e50f1fbc5a58963a1b1e462575249de61540f1 is the first bad commit
commit a7e50f1fbc5a58963a1b1e462575249de61540f1
Author: Jeromy <jeromyj@gmail.com>
Date:   Fri Jul 24 17:41:59 2015 -0700

    implement http trailers for errors after headers are sent

    refactor http handler and copyChunks to get this all to work correctly
    License: MIT
    Signed-off-by: Jeromy <jeromyj@gmail.com>

:040000 040000 4bbe16ab19466d3ebca59863f6ed19e58cd5fa5a aa4a0acff1d9eb6c1db6079873aaaab67b62579b M  commands

@whyrusleeping
Copy link
Member Author

The issue is that the final Read call on the client gets valid data and returns an error from the other side closing the connection.

@whyrusleeping
Copy link
Member Author

i suspect this is a go1.5 issue.

@whyrusleeping
Copy link
Member Author

fixed in #1621

@whyrusleeping whyrusleeping mentioned this issue Aug 30, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@whyrusleeping