Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPFS crashes on second run on windows #1661

Closed
slothbag opened this issue Sep 6, 2015 · 19 comments
Closed

IPFS crashes on second run on windows #1661

slothbag opened this issue Sep 6, 2015 · 19 comments

Comments

@slothbag
Copy link

slothbag commented Sep 6, 2015

I just compiled latest master and I could not start IPFS with this error:

Error: Post http://127.0.0.1:5001/api/v0/version?enc=json&stream-channels=true: dial tcp 127.0.0.1:5001: ConnectEx tcp: No connection could be made because the target machine actively refused it.

I issued a ipfs init and then I was able to start the daemon successfully. But after ctrl-c quiting the daemon I tried running it again and got the same error as above.

@myrkvi
Copy link

myrkvi commented Sep 11, 2015

I have the same issue with 0.3.8 on Windows 10.

@jbenet
Copy link
Member

jbenet commented Sep 14, 2015

Bizarre. @gatesvp ?

@Mithgol
Copy link

Mithgol commented Sep 16, 2015

I have the same problem with https://gobuilder.me/get/github.com/ipfs/go-ipfs/cmd/ipfs/ipfs_master_windows-amd64.zip on Windows 7, see #1713 (a closed duplicate of this issue) for a screenshot.

Not only ipfs daemon is affected but ipfs id as well.

@jbenet
Copy link
Member

jbenet commented Sep 16, 2015

:/ we need to fix this. Any ideas what's going on here? @whyrusleeping @gatesvp?


Sent from Mailbox

On Wed, Sep 16, 2015 at 2:47 AM, Mithgol notifications@github.com wrote:

I have the same problem with https://gobuilder.me/get/github.com/ipfs/go-ipfs/cmd/ipfs/ipfs_master_windows-amd64.zip on Windows 7, see #1713 for a screenshot.

Not only ipfs daemon is affected but ipfs id as well.

Reply to this email directly or view it on GitHub:
#1661 (comment)

@whyrusleeping
Copy link
Member

probably the locking library failing to properly clean up on exit. I'm not super knowledgeable on how windows file locking works, but we might have to special case some things if the syscalls arent reliable like they are on osx, linux and the bsd's

@gatesvp
Copy link
Contributor

gatesvp commented Sep 16, 2015

Was actually trying to look at this last night, but had a different problem
just trying to build the Windows version because of Symlinks in the main
repo.

Don't know if the problem is file locking or ports. Hope to spend some time
tonight debugging.

On Wed, Sep 16, 2015 at 9:13 AM, Jeromy Johnson notifications@github.com
wrote:

probably the locking library failing to properly clean up on exit. I'm not
super knowledgeable on how windows file locking works, but we might have to
special case some things if the syscalls arent reliable like they are on
osx, linux and the bsd's


Reply to this email directly or view it on GitHub
#1661 (comment).

@chriscool
Copy link
Contributor

If we want to properly support Windows, we might want to have automated builds and tests for this platform. Is there an issue somewhere for that or should I create one?

@gatesvp
Copy link
Contributor

gatesvp commented Sep 17, 2015

I feel like there was a ticket somewhere. One of the challenges with such a
ticket is effectively re-creating the sharness tests in say Windows
PowerShell.

Also, I managed to repro the problem locally last night, but still trying
to debug my way through the actual issue.

On Thu, Sep 17, 2015 at 7:58 AM, Christian Couder notifications@github.com
wrote:

If we want to properly support Windows, we might want to have automated
builds and tests for this platform. Is there an issue somewhere for that or
should I create one?


Reply to this email directly or view it on GitHub
#1661 (comment).

@Mithgol
Copy link

Mithgol commented Sep 24, 2015

This comment is just a nudge because ≈7 days have passed since the last comment here.

Please excuse my impatience.

@jbenet
Copy link
Member

jbenet commented Sep 24, 2015

Mithgol, can you help fix it? None of the core devs use windows. Gatesvp and others have done tremendous work on getting things working on windows, but we need everybody's help to move fast


Sent from Mailbox

On Thu, Sep 24, 2015 at 8:42 AM, Mithgol notifications@github.com wrote:

This comment is just a nudge because ≈7 days have passed since the last comment here.

Please excuse my impatience.

Reply to this email directly or view it on GitHub:
#1661 (comment)

@Mithgol
Copy link

Mithgol commented Sep 24, 2015

Unfortunately, I don't know Go. (Otherwise I would have already tried to help.)

@ghost
Copy link

ghost commented Sep 24, 2015

Hi, I worked around this in the referencing commit. I know neither Go nor ipfs codebase nor Windows APIs, so I don't know if this is the desired way of doing things.

@Mithgol
Copy link

Mithgol commented Sep 25, 2015

I know neither Go not IPFS codebase, but the line you added does look very much like the previous and thus it can't be much worse in terms of desired way of doing things.

You should make a pull request and become a contributor.

@jbenet jbenet closed this as completed in 20908b3 Sep 25, 2015
jbenet added a commit that referenced this issue Sep 25, 2015
Fix #1661 IPFS crashes on windows after first run
@jbenet
Copy link
Member

jbenet commented Sep 25, 2015

@mjanczyk thank you for the PR

@jbenet
Copy link
Member

jbenet commented Sep 25, 2015

and thanks @Mithgol for prompting it!

@richardschneider
Copy link

I don't know about the code. But the reason why we can't restart on windows, is the presence of the .../.ipfs/api file. If I delete it, then ipfs daemon works!

As suspected by others, its most likely a cleanup issue of the daemon.

@jbenet
Copy link
Member

jbenet commented Oct 14, 2015

  • is anyone having this issue in other systems?
  • @richardschneider what version? do you have latest 0.3.8?
  • @richardschneider i think this is another issue, if you're on latest and you still see it, pls open another issue

@slothbag
Copy link
Author

The original issue "crashing on second run in windows" has been fixed for a few weeks.

This ticket can be closed.

@richardschneider
Copy link

I'm running 0.3.8 and still having the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants