Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue building ipfs for ios #4210

Closed
whyrusleeping opened this issue Sep 6, 2017 · 5 comments
Closed

issue building ipfs for ios #4210

whyrusleeping opened this issue Sep 6, 2017 · 5 comments
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@whyrusleeping
Copy link
Member

Got an issue with reuseport:

why@whys-MacBook-Pro ~/code>
gomobile build -target=ios github.com/ipfs/go-ipfs/cmd/ipfs
gomobile: go build -pkgdir=/Users/why/go/pkg/gomobile/pkg_darwin_arm -tags ios -o=/var/folders/nc/q_yyfsf57bv5p1j26dh4stb40000gn/T/gomobile-work-450600580/arm github.com/ipfs/go-ipfs/cmd/ipfs failed: exit status 2
# gx/ipfs/QmVFEAZHvDvgFhGVmySEfejrzgBmWyHPdJhC3jDHDQjtzg/go-reuseport/singlepoll
../go/src/gx/ipfs/QmVFEAZHvDvgFhGVmySEfejrzgBmWyHPdJhC3jDHDQjtzg/go-reuseport/singlepoll/default.go:21:12: undefined: poll.New

@Kubuxu I think i remember you had a workaround, but it would be nice to make this 'just work'

@whyrusleeping whyrusleeping added the kind/bug A bug in existing code (including security flaws) label Sep 6, 2017
@Kubuxu
Copy link
Member

Kubuxu commented Sep 6, 2017

I thought I made it work.... Hmm.

@Kubuxu
Copy link
Member

Kubuxu commented Sep 6, 2017

This should allow it to build under ios, I have no idea why it doesn't work but I have no way to test it either: libp2p/go-reuseport@8d25e80

@whyrusleeping
Copy link
Member Author

@Kubuxu apparently its darwin,arm , not darwin,arm64

@whyrusleeping
Copy link
Member Author

why@whys-MacBook-Pro ~/g/s/g/j/go-reuseport> git diff
diff --git a/poll/poll_darwin_arm.go b/poll/poll_darwin_arm.go
index 602b38b..3b8dc2a 100644
--- a/poll/poll_darwin_arm.go
+++ b/poll/poll_darwin_arm.go
@@ -1,4 +1,4 @@
-// +build darwin,arm64
+// +build darwin,arm

 package poll

why@whys-MacBook-Pro ~/g/s/g/j/go-reuseport>
gomobile build -target=ios github.com/jbenet/go-reuseport

@Stebalien
Copy link
Member

This has now been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Development

No branches or pull requests

3 participants