Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash with "panic: send on closed channel" on master #7512

Closed
gmasgras opened this issue Jun 26, 2020 · 0 comments · Fixed by #7517
Closed

Crash with "panic: send on closed channel" on master #7512

gmasgras opened this issue Jun 26, 2020 · 0 comments · Fixed by #7517
Assignees
Labels
effort/hours Estimated to take one or several hours exp/expert Having worked on the specific codebase is important kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up topic/libp2p Topic libp2p

Comments

@gmasgras
Copy link

Version information:

go-ipfs version: 0.7.0-dev-b86e930
Repo version: 10
System version: amd64/linux
Golang version: go1.14.4

Description:

go-ipfs running on staging instance crashes multiple times per day with panic: send on closed channel
Sample log:

2020-06-26T06:25:16.406827+00:00 localhost ipfs[31912]: Daemon is ready
2020-06-26T06:26:36.797588+00:00 localhost ipfs[31912]: panic: send on closed channel
2020-06-26T06:26:36.798688+00:00 localhost ipfs[31912]: goroutine 153572 [running]:
2020-06-26T06:26:36.799049+00:00 localhost ipfs[31912]: github.com/lucas-clemente/quic-go/qlog.(*tracer).recordEvent(...)
2020-06-26T06:26:36.799282+00:00 localhost ipfs[31912]: #011pkg/mod/github.com/lucas-clemente/quic-go@v0.16.2/qlog/qlog.go:131
2020-06-26T06:26:36.799506+00:00 localhost ipfs[31912]: github.com/lucas-clemente/quic-go/qlog.(*tracer).ReceivedVersionNegotiationPacket(0xc01b0a9b00, 0xc01640fa80)
2020-06-26T06:26:36.799728+00:00 localhost ipfs[31912]: #011pkg/mod/github.com/lucas-clemente/quic-go@v0.16.2/qlog/qlog.go:254 +0x2c1
2020-06-26T06:26:36.799950+00:00 localhost ipfs[31912]: github.com/lucas-clemente/quic-go.(*client).handleVersionNegotiationPacket(0xc0005cd880, 0xc019906f50)
2020-06-26T06:26:36.800250+00:00 localhost ipfs[31912]: #011pkg/mod/github.com/lucas-clemente/quic-go@v0.16.2/client.go:364 +0x5f8
2020-06-26T06:26:36.800486+00:00 localhost ipfs[31912]: created by github.com/lucas-clemente/quic-go.(*client).handlePacket
2020-06-26T06:26:36.800712+00:00 localhost ipfs[31912]: #011pkg/mod/github.com/lucas-clemente/quic-go@v0.16.2/client.go:316 +0xb8
2020-06-26T22:30:10.705163+00:00 localhost ipfs[6640]: Daemon is ready
2020-06-26T22:30:34.870103+00:00 localhost ipfs[6640]: panic: send on closed channel
2020-06-26T22:30:34.870987+00:00 localhost ipfs[6640]: goroutine 76247 [running]:
2020-06-26T22:30:34.871201+00:00 localhost ipfs[6640]: github.com/lucas-clemente/quic-go/qlog.(*tracer).recordEvent(...)
2020-06-26T22:30:34.871466+00:00 localhost ipfs[6640]: #011pkg/mod/github.com/lucas-clemente/quic-go@v0.16.2/qlog/qlog.go:131
2020-06-26T22:30:34.871638+00:00 localhost ipfs[6640]: github.com/lucas-clemente/quic-go/qlog.(*tracer).ReceivedVersionNegotiationPacket(0xc01d8feb40, 0xc015999100)
2020-06-26T22:30:34.871809+00:00 localhost ipfs[6640]: #011pkg/mod/github.com/lucas-clemente/quic-go@v0.16.2/qlog/qlog.go:254 +0x2c1
2020-06-26T22:30:34.871971+00:00 localhost ipfs[6640]: github.com/lucas-clemente/quic-go.(*client).handleVersionNegotiationPacket(0xc01979f0a0, 0xc015457130)
2020-06-26T22:30:34.872189+00:00 localhost ipfs[6640]: #011pkg/mod/github.com/lucas-clemente/quic-go@v0.16.2/client.go:364 +0x5f8
2020-06-26T22:30:34.872355+00:00 localhost ipfs[6640]: created by github.com/lucas-clemente/quic-go.(*client).handlePacket
2020-06-26T22:30:34.872515+00:00 localhost ipfs[6640]: #011pkg/mod/github.com/lucas-clemente/quic-go@v0.16.2/client.go:316 +0xb8
2020-06-26T22:30:35.921672+00:00 localhost ipfs[6989]: Daemon is ready
2020-06-26T22:41:42.393766+00:00 localhost ipfs[6989]: panic: send on closed channel
2020-06-26T22:41:42.394251+00:00 localhost ipfs[6989]: goroutine 1505667 [running]:
2020-06-26T22:41:42.394472+00:00 localhost ipfs[6989]: github.com/lucas-clemente/quic-go/qlog.(*tracer).recordEvent(...)
2020-06-26T22:41:42.394759+00:00 localhost ipfs[6989]: #011pkg/mod/github.com/lucas-clemente/quic-go@v0.16.2/qlog/qlog.go:131
2020-06-26T22:41:42.394966+00:00 localhost ipfs[6989]: github.com/lucas-clemente/quic-go/qlog.(*tracer).ReceivedVersionNegotiationPacket(0xc02d4d8480, 0xc01cb73900)
2020-06-26T22:41:42.395175+00:00 localhost ipfs[6989]: #011pkg/mod/github.com/lucas-clemente/quic-go@v0.16.2/qlog/qlog.go:254 +0x2c1
2020-06-26T22:41:42.395395+00:00 localhost ipfs[6989]: github.com/lucas-clemente/quic-go.(*client).handleVersionNegotiationPacket(0xc01b96c8c0, 0xc03592f2c0)
2020-06-26T22:41:42.395597+00:00 localhost ipfs[6989]: #011pkg/mod/github.com/lucas-clemente/quic-go@v0.16.2/client.go:364 +0x5f8
2020-06-26T22:41:42.395799+00:00 localhost ipfs[6989]: created by github.com/lucas-clemente/quic-go.(*client).handlePacket
2020-06-26T22:41:42.395996+00:00 localhost ipfs[6989]: #011pkg/mod/github.com/lucas-clemente/quic-go@v0.16.2/client.go:316 +0xb8
@gmasgras gmasgras added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization labels Jun 26, 2020
@gmasgras gmasgras changed the title Crash with "panic: send on closed channel" on master Crash with "panic: send on closed channel" on master Jun 26, 2020
@Stebalien Stebalien added exp/expert Having worked on the specific codebase is important effort/hours Estimated to take one or several hours P2 Medium: Good to have, but can wait until someone steps up topic/libp2p Topic libp2p and removed need/triage Needs initial labeling and prioritization labels Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/hours Estimated to take one or several hours exp/expert Having worked on the specific codebase is important kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up topic/libp2p Topic libp2p
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants