Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows builds fix #1875

Merged
merged 4 commits into from Oct 29, 2015
Merged

windows builds fix #1875

merged 4 commits into from Oct 29, 2015

Conversation

whyrusleeping
Copy link
Member

this fixes builds on windows, and also fixes a couple of the test failures (not all of them, just some of the easy ones i saw)

@whyrusleeping
Copy link
Member Author

This also now makes windows builds part of the CI process.

@cryptix
Copy link
Contributor

cryptix commented Oct 23, 2015

I don't see where wmi and ole are used? Or does the import in sadhack trigger some init hooks?

rest LGTM

@whyrusleeping
Copy link
Member Author

@cryptix theyre used in the library we're importing to gather system diagnostics information gopsutil, only on windows.

@cryptix
Copy link
Contributor

cryptix commented Oct 23, 2015

Aah.. I see! maybe want to group them with comment together with github.com/olekukonko/ts (same storry)

@whyrusleeping
Copy link
Member Author

probably a good idea.

@Mithgol
Copy link

Mithgol commented Oct 24, 2015

You may ignore this comment because its only purpose is to make this issue to appear in my https://github.com/notifications/participating

I want to be automatically notified when a working IPFS build for Windows appears.

@whyrusleeping
Copy link
Member Author

@Mithgol there is a button on the side of the issue you can click to subscribe to issue notifications.

@Mithgol
Copy link

Mithgol commented Oct 24, 2015

@whyrusleeping I know, but that button adds this issue to the long list https://github.com/notifications/ but not to the shorter list https://github.com/notifications/participating (unless I have misunderstood something).

@whyrusleeping
Copy link
Member Author

@Mithgol please dont do that, it just adds noise to the comment chain, the comment chain for pull requests is intended just for code review, if there is an open issue about windows builds failing you can comment there to subscribe to notifications, or if there isnt one, you can open an issue, and mention this PR in the issue. Otherwise, just use the subscribe button here.

@jbenet
Copy link
Member

jbenet commented Oct 27, 2015

@whyrusleeping maybe rebase, since it's big?

@whyrusleeping
Copy link
Member Author

rebased.

@whyrusleeping
Copy link
Member Author

@jbenet RFM?

@jbenet
Copy link
Member

jbenet commented Oct 28, 2015

@whyrusleeping this still needs rebasing

# since we have CI for osx and linux but not windows, this should help
windows_build_check:
GOOS=windows GOARCH=amd64 go build -tags=nofuse ./cmd/ipfs
rm ipfs.exe
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice to place it somewhere the user may not have one they use. lime use the output flag and put it in .ipfs.exe or something

License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
jbenet added a commit that referenced this pull request Oct 29, 2015
@jbenet jbenet merged commit 3c8c729 into master Oct 29, 2015
@jbenet jbenet deleted the fix/windows-builds branch October 29, 2015 07:10
@jbenet
Copy link
Member

jbenet commented Oct 29, 2015

@Mithgol want to test master now?

@Mithgol
Copy link

Mithgol commented Oct 29, 2015

@jbenet currently it does not seem like there is a Windows build of IPFS at https://gobuilder.me/github.com/ipfs/go-ipfs/cmd/ipfs

@cryptix
Copy link
Contributor

cryptix commented Oct 29, 2015

Still choked on <go1.5

@Mithgol
Copy link

Mithgol commented Oct 31, 2015

IPFS version 0.3.9 on Windows seems fine (i.e. I haven't encountered any obvious errors yet).

@jbenet
Copy link
Member

jbenet commented Oct 31, 2015

@Mithgol great to hear! sorry it took so long

@whyrusleeping whyrusleeping mentioned this pull request Nov 2, 2015
47 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants