Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--help: Add a note on using IPFS_PATH to the footer of the helptext. #1981

Merged
merged 1 commit into from
Dec 2, 2015

Conversation

sahib
Copy link
Contributor

@sahib sahib commented Nov 19, 2015

I couldn't find this piece of information in the official docs, just scattered over a few issues on GitHub.

@GitCop
Copy link

GitCop commented Nov 19, 2015

There were the following issues with your Pull Request

  • Commit: 86b2081
    • Invalid signoff. Commit message must end with
      License: MIT
      Signed-off-by: .* <.*>

Guidelines and a script are available to help. Your feedback on GitCop is welcome on this issue.


This message was auto-generated by https://gitcop.com

@@ -69,6 +69,9 @@ TOOL COMMANDS
commands List all available commands

Use 'ipfs <command> --help' to learn more about each command.

If you want to operate on a different repository than the default at ~/.ipfs,
then prefix any ipfs command with IPFS_PATH=/path.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would phrase this a little different, to give the reader a more clear idea of whats going on:

"You may set the IPFS_PATH environment variable to make ipfs use a different location for its on disk repo."

Or something, cc @jbenet @RichardLitt

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sahib This is a great add! But I agree, it is worded a bit strange. How about:

If you want IPFS to use a different directory locally than the default ~/.ipfs, set the IPFS_PATH environment variable to point to your preferred directory.

Sahib, do you know how to amend commits?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used your suggestion and updated the pull request.

Sahib, do you know how to amend commits?

I just squashed my commits to one.
(Had to use git push --force but I guess nobody used that commit yet...)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@RichardLitt
Copy link
Member

LGTM!

@@ -69,6 +69,9 @@ TOOL COMMANDS
commands List all available commands

Use 'ipfs <command> --help' to learn more about each command.

If you want IPFS to use a different directory locally than the default ~/.ipfs,
set the IPFS_PATH environment variable to point to your preferred directory.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this (+ example):

ipfs uses a repo (repository) in the local file system. By default, the repo is located
at ~/.ipfs. To change the repo location, set the $IPFS_PATH environment variable:

    export IPFS_PATH=/path/to/ipfsrepo

@jbenet
Copy link
Member

jbenet commented Nov 30, 2015

LGTM thanks-- one minor edit above. sorry for the delay @sahib

License: MIT
Signed-off-by: Chris P. <sahib@online.de>
@sahib
Copy link
Contributor Author

sahib commented Dec 2, 2015

@jbenet: Changed. Only change from your suggestion was spelling out repository long the first time and abbreviating afterwards.

@RichardLitt
Copy link
Member

lgtm. Thanks.

jbenet added a commit that referenced this pull request Dec 2, 2015
--help: Add a note on using IPFS_PATH to the footer of the helptext.
@jbenet jbenet merged commit 4fd2844 into ipfs:master Dec 2, 2015
@jbenet jbenet removed the backlog label Dec 2, 2015
@jbenet
Copy link
Member

jbenet commented Dec 2, 2015

thanks @sahib !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants