Use newer flatfs sharding scheme #3608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateon1
reviewed
Jan 19, 2017
| @@ -35,7 +35,7 @@ func openDefaultDatastore(r *FSRepo) (repo.Datastore, error) { | |||
| syncfs := !r.config.Datastore.NoSync | |||
| // 5 bytes of prefix gives us 25 bits of freedom, 16 of which are taken by | |||
| // by the Qm prefix. Leaving us with 9 bits, or 512 way sharding | |||
| blocksDS, err := flatfs.New(path.Join(r.path, flatfsDirectory), 5, syncfs) | |||
| blocksDS, err := flatfs.CreateOrOpen(path.Join(r.path, flatfsDirectory), flatfs.NextToLast(2), syncfs) | |||
There was a problem hiding this comment.
The comment needs to be updated as well. (again)
If I understand correctly, that this is the last two base32 characters, it's 10 bits of sharding.
There was a problem hiding this comment.
@mateon1 good catch on the comment. Yeah, its the second to last two base32 characters (since the last character doesnt have 10 full bits of entropy)
whyrusleeping
force-pushed
the
feat/new-flatfs-sharding
branch
4 times, most recently
from
8857567
to
1366795
Compare
License: MIT Signed-off-by: Jeromy <why@ipfs.io>
Kubuxu
approved these changes
Jan 20, 2017
|
Alright, here goes |
|
CHANGELOG: |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
License: MIT
Signed-off-by: Jeromy why@ipfs.io