New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filestore: add "--file-order" option to "filestore ls" and "verify" #3938

Merged
merged 1 commit into from May 24, 2017

Conversation

Projects
None yet
4 participants
@kevina
Contributor

kevina commented May 23, 2017

Closes #3922

@dokterbob

This comment has been minimized.

Contributor

dokterbob commented May 23, 2017

Just tested it and it's uncomparably faster! Thanks!

return listAll(fs, false)
func ListAll(fs *Filestore, fileOrder bool) (func() *ListRes, error) {
if fileOrder {
println("ListAll With Sort")

This comment has been minimized.

@whyrusleeping

whyrusleeping May 23, 2017

Member

don't use println

This comment has been minimized.

@kevina

kevina May 23, 2017

Contributor

sorry, that was meant for debugging and I forgot to remove it

return nil
}
v := entries[i]
i += 1

This comment has been minimized.

@whyrusleeping
@whyrusleeping

A couple comments, otherwise LGTM

@kevina

This comment has been minimized.

Contributor

kevina commented May 23, 2017

@whyrusleeping

A couple comments

Fixed.

@whyrusleeping

This comment has been minimized.

Member

whyrusleeping commented May 23, 2017

@kevina also a couple codeclimate issues

@kevina

This comment has been minimized.

Contributor

kevina commented May 23, 2017

@whyrusleeping I know. It is being two picky. The check is "Indent Error Flow", but this is not an error flow. There is nothing is the style guide at https://github.com/golang/go/wiki/CodeReviewComments about this, the style guide is specially about error handling.

@kevina

This comment has been minimized.

Contributor

kevina commented May 23, 2017

Also golint had this disclaimer in the README:

The suggestions made by golint are exactly that: suggestions. Golint is not perfect, and has both false positives and false negatives. Do not treat its output as a gold standard. We will not be adding pragmas or other knobs to suppress specific warnings, so do not expect or require code to be completely "lint-free". In short, this tool is not, and will never be, trustworthy enough for its suggestions to be enforced automatically, for example as part of a build process. Golint makes suggestions for many of the mechanically checkable items listed in Effective Go and the CodeReviewComments wiki page.

@whyrusleeping

This comment has been minimized.

Member

whyrusleeping commented May 23, 2017

@kevina you have redundant else statements. It makes the code cleaner to remove them

filestore: add "--file-order" option to "filestore ls" and "verify"
License: MIT
Signed-off-by: Kevin Atkinson <k@kevina.org>
@kevina

This comment has been minimized.

Contributor

kevina commented May 23, 2017

@whyrusleeping I don't agree, but its not worth an argument, fixed.

@Kubuxu

Kubuxu approved these changes May 24, 2017

@whyrusleeping whyrusleeping merged commit e61e4d2 into master May 24, 2017

6 of 8 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
ci/circleci Your tests passed on CircleCI!
Details
codeclimate no new or fixed issues
Details
codecov/patch 77.04% of diff hit (target 63.89%)
Details
codecov/project 64% (+0.11%) compared to 27ebaab
Details
commit-message-check/gitcop All commit messages are valid
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

@whyrusleeping whyrusleeping deleted the kevina/filestore-verify-sort branch May 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment