New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure non-self keys also get republished #3951

Merged
merged 2 commits into from Jun 10, 2017

Conversation

Projects
None yet
2 participants
@kevina
Copy link
Contributor

kevina commented Jun 1, 2017

Closes #3808

@whyrusleeping

This comment has been minimized.

Copy link
Member

whyrusleeping commented Jun 3, 2017

👍 i really like the approach. Will make it easy when we migrate to having the primary identity key in the keystore.

@kevina

This comment has been minimized.

Copy link
Contributor

kevina commented Jun 3, 2017

@whyrusleeping thanks, do you want me to go ahead and rebase and squash this?

@whyrusleeping

This comment has been minimized.

Copy link
Member

whyrusleeping commented Jun 7, 2017

@kevina yeah, i'd go ahead and move forward here

@kevina kevina force-pushed the kevina/repub branch from b4444e5 to 627b253 Jun 7, 2017

@kevina kevina changed the title Super WIP: Make sure non-self keys also get republished Make sure non-self keys also get republished Jun 7, 2017

@kevina

This comment has been minimized.

Copy link
Contributor

kevina commented Jun 7, 2017

@whyrusleeping rebased and squashed.

repub: iterate through all keys in keystore
Iterate through all keys in the keystore so keys added with
"ipfs key gen" behave the same as the <self> key.  Don't maintain a
separate repub list as it does not really serve a purpose at this
point in time.  See #3808.

License: MIT
Signed-off-by: Kevin Atkinson <k@kevina.org>

@kevina kevina force-pushed the kevina/repub branch from 627b253 to d674dd7 Jun 7, 2017

@whyrusleeping
Copy link
Member

whyrusleeping left a comment

This LGTM. Would enjoy finding a way to avoid those long sleeps in the tests, but thats out of scope here.

@whyrusleeping whyrusleeping requested a review from Kubuxu Jun 9, 2017

@kevina

This comment has been minimized.

Copy link
Contributor

kevina commented Jun 9, 2017

@whyrusleeping I made one last tweak. I kept it is a separate commit so you can see what is changed. I can squash it if you want.

@whyrusleeping

This comment has been minimized.

Copy link
Member

whyrusleeping commented Jun 10, 2017

@kevina as far as i can tell, entrylock is no longer used either. Good catch

repub: remove unused field
License: MIT
Signed-off-by: Kevin Atkinson <k@kevina.org>

@kevina kevina force-pushed the kevina/repub branch from 4805e8d to 1fe6e18 Jun 10, 2017

@whyrusleeping

This comment has been minimized.

Copy link
Member

whyrusleeping commented Jun 10, 2017

Thanks @kevina :)

@whyrusleeping whyrusleeping merged commit 10f9e77 into master Jun 10, 2017

6 of 8 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
codecov/patch 54.54% of diff hit (target 63.82%)
Details
ci/circleci Your tests passed on CircleCI!
Details
codeclimate 3 fixed issues
Details
codecov/project 63.94% (+0.12%) compared to c6b37e6
Details
commit-message-check/gitcop All commit messages are valid
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@whyrusleeping whyrusleeping deleted the kevina/repub branch Jun 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment