Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix default-net profile not reverting bootstrap config #4845

Merged
merged 2 commits into from Apr 9, 2018
Merged

fix default-net profile not reverting bootstrap config #4845

merged 2 commits into from Apr 9, 2018

Conversation

magik6k
Copy link
Member

@magik6k magik6k commented Mar 20, 2018

Fixes #4842

@magik6k magik6k requested a review from Kubuxu as a code owner March 20, 2018 15:57
@ghost ghost assigned magik6k Mar 20, 2018
@ghost ghost added the status/in-progress In progress label Mar 20, 2018
@Kubuxu Kubuxu added RFM and removed status/in-progress In progress labels Mar 23, 2018
@whyrusleeping
Copy link
Member

@magik6k mind adding a small sharness test for this?

@ghost ghost added the status/in-progress In progress label Mar 30, 2018
@magik6k
Copy link
Member Author

magik6k commented Mar 30, 2018

Done

@whyrusleeping
Copy link
Member

@magik6k I merged your other PR first, need to resolve the conflicts

@magik6k
fix default-net profile not reverting bootstrap config
5a632f7 
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
@magik6k
profile: fix test profile tests
dd23bec 
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
@magik6k
Copy link
Member Author

magik6k commented Apr 8, 2018

Rebased

@whyrusleeping whyrusleeping merged commit 0cb22cc into master Apr 9, 2018
@ghost ghost removed the status/in-progress In progress label Apr 9, 2018
@whyrusleeping whyrusleeping deleted the fix/default-net-bootstrap branch April 9, 2018 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kubuxu Kubuxu Kubuxu approved these changes

Assignees

@magik6k magik6k

Labels
RFM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@magik6k @whyrusleeping @Kubuxu