Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin: preload git plugin by default #4991

Merged
merged 3 commits into from
Jun 13, 2018
Merged

Conversation

magik6k
Copy link
Member

@magik6k magik6k commented May 1, 2018

Suggested by @lgierth an IRC, enabling the git plugin is rather painful experience for anyone wanting to do anything git related:

  • Linux users have to setup Go workspace, compile the plugin and then put in a right directory
  • All the others (osx/windows/*) have to setup Go workspace, unncomment ipldgit line in preload file and compile/install go-ipfs (bonus pain points when using something like ipfs-desktop)

Adding the plugin to preload_list adds about 100K to the binary size, and given that it is 43M it's rather negligible.

License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
@magik6k magik6k requested a review from Kubuxu as a code owner May 1, 2018 11:34
@ghost ghost assigned magik6k May 1, 2018
@ghost ghost added the status/in-progress In progress label May 1, 2018
Copy link
Member

@Kubuxu Kubuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plugin would have to be imported through gx for it to work.

Can you figure out why CI failed?

License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
@ghost
Copy link

ghost commented May 1, 2018

Adding the plugin to preload_list adds about 100K to the binary size, and given that it is 43M it's rather negligible.

Being able to do Git things is absolutely worth the 100KB :)

@Kubuxu Kubuxu added RFM and removed status/in-progress In progress labels May 2, 2018
@whyrusleeping
Copy link
Member

The sha1 object thing by default bothers me slightly. Maybe we should just put efforts into getting the plugins up on dists?

@ghost
Copy link

ghost commented May 12, 2018

Maybe let's couple allowing sha1 to git CIDs only then. We'll have the same issue with js-ipfs and ipfs-companion.

@whyrusleeping
Copy link
Member

Alright, fine. You guys win this battle

@whyrusleeping whyrusleeping merged commit 1f3a5fe into master Jun 13, 2018
@whyrusleeping whyrusleeping deleted the feat/git-plugin-default branch June 13, 2018 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants