name cmd: move subcommands to subdirectory #5392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
magik6k
force-pushed
the
refactor/name-cmd-dir
branch
2 times, most recently
from
2a3008b
to
8aa1fa8
Compare
Stebalien
reviewed
Aug 21, 2018
core/commands/name/ipns.go
Outdated
| } | ||
| return strings.NewReader(output.Path.String() + "\n"), nil | ||
| }, | ||
| _, err := w.Write([]byte(output.Path.String() + "\n")) |
There was a problem hiding this comment.
Minor nit but we might as well use fmt.Writeln(w, output.Path.String()).
core/commands/name/ipnsps.go
Outdated
| @@ -71,17 +71,18 @@ var ipnspsStateCmd = &cmds.Command{ | |||
| state = "disabled" | |||
| } | |||
|
|
|||
| return strings.NewReader(state + "\n"), nil | |||
| }, | |||
| _, err := w.Write([]byte(state + "\n")) | |||
core/commands/name/ipnsps.go
Outdated
| @@ -164,7 +160,26 @@ var ipnspsCancelCmd = &cmds.Command{ | |||
| state = "no subscription" | |||
| } | |||
|
|
|||
| return strings.NewReader(state + "\n"), nil | |||
| }, | |||
| _, err := w.Write([]byte(state + "\n")) | |||
Stebalien
force-pushed
the
refactor/name-cmd-dir
branch
from
8aa1fa8
to
08ac497
Compare
Stebalien
force-pushed
the
refactor/name-cmd-dir
branch
from
08ac497
to
965a54e
Compare
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
magik6k
force-pushed
the
refactor/name-cmd-dir
branch
from
965a54e
to
b0c480a
Compare
License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien
force-pushed
the
refactor/name-cmd-dir
branch
from
f0886f0
to
faf7aac
Compare
Stebalien
approved these changes
Aug 22, 2018
|
@magik6k can you check over my latest change? If that looks good to you, I'll merge. |
|
Meh. This is actually just ready to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just wanted to do this before
ipfs name resolve --streamGetApi/GetNodeutils to subpkg to avoid duplicating themipns namecommands into a sub-package