Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep: update go-libp2p #6361

Merged
merged 1 commit into from
May 22, 2019
Merged

dep: update go-libp2p #6361

merged 1 commit into from
May 22, 2019

Conversation

Stebalien
Copy link
Member

fixes #6237

The relay now resets the underlying stream when closing the transport connection so closing doesn't block up the entire connection manager.

See: libp2p/go-libp2p-circuit#76

@Stebalien Stebalien changed the title dep: update go-libp2p-circuit dep: update go-libp2p May 22, 2019
@Stebalien Stebalien marked this pull request as ready for review May 22, 2019 18:12
@Stebalien Stebalien force-pushed the fix/6237 branch 2 times, most recently from f331f23 to 449a511 Compare May 22, 2019 18:30
* Write coalescing in yamux and mplex.
* Correctly tag relay streams.
* Reset relay streams instead of closing them. Fixes #6237.
* Trim connections in a background task instead of on-connect.
@Stebalien
Copy link
Member Author

(dep update, merging without review)

@Stebalien Stebalien merged commit 1852452 into master May 22, 2019
@Stebalien Stebalien deleted the fix/6237 branch May 22, 2019 19:51
Stebalien added a commit that referenced this pull request May 22, 2019
I introduced this by accident in #6361 when I switched from explicitly
initializing everything to overriding specific config variables.
Stebalien added a commit that referenced this pull request May 22, 2019
Accidentally added in #6361. The yamux transport now disables this globally by
default.
@Stebalien Stebalien restored the fix/6237 branch May 30, 2019 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Too many open files (regression?)
1 participant