Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libp2p: moves discovery after host listen #6415

Merged
merged 1 commit into from
Jun 6, 2019

Conversation

sanderpick
Copy link
Contributor

Prevents the MDNS server from starting when the host has zero addresses.

Re: libp2p/go-libp2p#652

Prevents the MDNS server from starting when the host has zero addresses.

Re: libp2p/go-libp2p#652

Signed-off-by: Sander Pick <sanderpick@gmail.com>
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

This is probably also triggering #6359 (because we aren't passing an IP address so it's trying to discover it).

@Stebalien Stebalien merged commit 505eeed into ipfs:master Jun 6, 2019
magik6k added a commit that referenced this pull request Jun 7, 2019
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
Stebalien added a commit that referenced this pull request Jul 4, 2019
libp2p: moves discovery after host listen
@Stebalien Stebalien mentioned this pull request Jul 12, 2019
51 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants