Sharness macos no brainer fixes #6805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54b1969 correctly switched from nc to socat, but did not account for it not being as widely available. Adjust tests that depend on it with the correct message. There are also a number of comments pertaining to nc - they were not adjusted.
Docker on a mac might be available, but may not be runnng. The way the original test was written is linux-specific anyway, so just hoist the check into the DOCKER declaration
Set this to '1' if you are doing local dev and have redirects in go.mod
Some did actually prevent proper test shutdown
Without reflecting this in the tests we do not actually shut down correctly during cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the "no brainer" part of #6799