Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(sharness): test our tests #6908

Merged
merged 1 commit into from Feb 18, 2020
Merged

test(sharness): test our tests #6908

merged 1 commit into from Feb 18, 2020

Conversation

Stebalien
Copy link
Member

@Stebalien Stebalien commented Feb 18, 2020 •
edited

Make sure they:

  1. Report that they're done. Otherwise, we'll silently succeed.
  2. Have a description.
  3. Make sure we cleanup IPFS.

These are simple sanity checks to make sure we're not ignoring bugs in our tests.

@Stebalien
test(sharness): test our tests
6e8c25e 
Make sure they:

1. Report that they're done. Otherwise, we'll silently succeed.
2. Have a description.
3. Make sure we cleanup IPFS.
dirkmc
dirkmc approved these changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@dirkmc dirkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very meta :)

@Stebalien Stebalien merged commit 25fbf19 into master Feb 18, 2020
@Stebalien Stebalien deleted the test/test-sharness-tests branch February 18, 2020 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirkmc dirkmc dirkmc approved these changes

@aschmahmann aschmahmann Awaiting requested review from aschmahmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Stebalien @dirkmc