fix(keystore): avoid racy filesystem access #6999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsanjuan
force-pushed
the
feat/AuHau-encoding-key-names
branch
from
13f0c20
to
cbb4017
Compare
|
hmm good catch |
Stebalien
force-pushed
the
feat/AuHau-encoding-key-names
branch
2 times, most recently
from
2a27519
to
0d9d6e9
Compare
Instead of checking then performing a file operation, perform the file operation and check the error.
Stebalien
force-pushed
the
fix/racy-fs-access
branch
from
a190b04
to
7a4c377
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of checking then performing a file operation, perform the file operation and check the error.
Merge to master after the base PR. I'm just filing this now so I don't forget.