feat: improve key lookup #7023
Merged
feat: improve key lookup #7023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Stebalien
commented
Mar 23, 2020
Stebalien
commented
- Support peer IDs encoded as CIDs.
- Support looking up the identity key by peer ID.
hsanjuan
reviewed
Mar 23, 2020
| @@ -170,7 +194,7 @@ func keylookup(self ci.PrivKey, kstore keystore.Keystore, k string) (ci.PrivKey, | |||
| return nil, err | |||
There was a problem hiding this comment.
Why is it not doing IDFromPrivateKey(privKey) directly?
There was a problem hiding this comment.
Just a couple of lines above, could not add comment directly there.
There was a problem hiding this comment.
No idea. It may not have existed? I'll change that.
core/coreapi/name.go
Outdated
| // First, check self. | ||
| pid, err := peer.IDFromPrivateKey(self) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to determine peer ID for private key") |
There was a problem hiding this comment.
Not including the original error message?
* Support peer IDs encoded as CIDs. * Support looking up the identity key by peer ID.
Stebalien
force-pushed
the
fix/improve-key-lookup
branch
from
d313e72
to
b5ad3be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.