Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keystore: minor maintenance #7043

Merged
merged 2 commits into from Mar 27, 2020
Merged

Keystore: minor maintenance #7043

merged 2 commits into from Mar 27, 2020

Conversation

hsanjuan
Copy link
Contributor 

keystore: Switch from Bytes() to MarshalPrivateKey()

Bytes is deprecated.

keystore: create new keys with 0400 permissions (as spec'ed) 

Spec is pretty much out of date but specifies this.

https://github.com/ipfs/specs/blob/master/KEYSTORE.md

@hsanjuan hsanjuan self-assigned this Mar 27, 2020
@hsanjuan
Copy link
Contributor Author

Am I too lazy for sending two unrelated changes in the same PR or is this ok?

ribasushi
ribasushi approved these changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@ribasushi ribasushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Stebalien Stebalien merged commit f1efab4 into master Mar 27, 2020
@hsanjuan hsanjuan deleted the fix/keystore-fixes branch March 27, 2020 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ribasushi ribasushi ribasushi approved these changes

Assignees

@hsanjuan hsanjuan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hsanjuan @ribasushi @Stebalien