Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add autonat config options #7162

Merged
merged 2 commits into from Apr 15, 2020
Merged

add autonat config options #7162

merged 2 commits into from Apr 15, 2020

Conversation

Stebalien
Copy link
Member

  1. Enable AutoNATService on all nodes by default. If it's an issue, we can disable it in RC3 but this will give us the best testing results.
  2. Expose options to configure AutoNAT rate limiting.

@Stebalien
chore: update bitswap
9a98410 
Remove some allocation hotspots
@Stebalien Stebalien requested review from alanshaw and willscott and removed request for alanshaw April 15, 2020 03:49
willscott
willscott approved these changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@willscott willscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it worth noting that Enabled actually means that the service will become active if it determines the local node is publicly reachable by others?

@Stebalien
Copy link
Member Author

is it worth noting that Enabled actually means that the service will become active if it determines the local node is publicly reachable by others?

Didn't we change that default to "if it doesn't know that it's not reachable"?

@Stebalien
Copy link
Member Author

But yeah, I'll quickly document that.

@Stebalien
feat: add autonat config options
1f23fc0 
1. Enable AutoNATService on _all_ nodes by default. If it's an issue, we can
disable it in RC3 but this will give us the best testing results.
2. Expose options to configure AutoNAT rate limiting.
@Stebalien Stebalien merged commit d336d91 into master Apr 15, 2020
@Stebalien Stebalien deleted the feat/autonat-conf branch April 15, 2020 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willscott willscott willscott approved these changes

Assignees
No one assigned
Labels
need_tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Stebalien @willscott