Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update webui to 2.12.2 #8097

Merged
merged 2 commits into from
May 5, 2021
Merged

chore: update webui to 2.12.2 #8097

merged 2 commits into from
May 5, 2021

Conversation

Stebalien
Copy link
Member

@Stebalien Stebalien commented Apr 28, 2021 •
edited by lidel
Loading

Closes #7559

@Stebalien Stebalien requested a review from lidel April 28, 2021 18:02
@lidel lidel added the status/blocked Unable to be worked further until needs are met label Apr 29, 2021
@lidel
Copy link
Member

lidel commented Apr 29, 2021

It seems to work fine with ipfs-desktop first ipfs/ipfs-desktop#1807 but we need v2.12.2 with ipfs/ipfs-webui#1772 / #8096 before this can land.

@lidel lidel changed the title chore: update webui to 2.12.1 chore: update webui to 2.12.2 Apr 30, 2021
@lidel lidel removed the status/blocked Unable to be worked further until needs are met label Apr 30, 2021
@lidel
Copy link
Member

lidel commented Apr 30, 2021 •
edited
Loading

Bumped to ipfs-webui 2.12.2 , testing in progress at:

@lidel
Copy link
Member

lidel commented May 5, 2021

FYSA ipfs-desktop shipped with ipfs-webui v2.12.2 (bumped this PR to the same version).
I wanted to wait a bit to test this in the wild, and looks ok. There seem to be no fires or huge regressions.

@Stebalien @aschmahmann
I feel we should ship this with 0.9.0 just to avoid having different UI in go-ipfs and ipfs-desktop.
If we keep old one, users will be asking why they are missing "remote pinning" UI or "why Files header looks different", and it is better to spend time in fixing latest webui (if needed) than triaging those empty issues.

@lidel lidel added this to the go-ipfs 0.9 milestone May 5, 2021
@lidel lidel mentioned this pull request May 5, 2021
Closed
6 tasks
@Stebalien
Copy link
Member Author

@lidel SGTM. Want to approve this PR?

@lidel lidel added the topic/webui Topic webui label May 5, 2021
lidel
lidel approved these changes May 5, 2021
View reviewed changes
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@Stebalien Stebalien merged commit 71761a6 into master May 5, 2021
@Stebalien Stebalien deleted the chore/update-webui branch May 5, 2021 21:17
@aschmahmann aschmahmann mentioned this pull request May 14, 2021
Closed
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel lidel approved these changes

Assignees
No one assigned
Labels
topic/webui Topic webui
Projects
None yet
Milestone
go-ipfs 0.9
Development

Successfully merging this pull request may close these issues.

Add support for remote Pinning Services
2 participants
@Stebalien @lidel