Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: move Docker image build to Actions #8467

Merged
merged 2 commits into from Sep 28, 2021
Merged

ci: move Docker image build to Actions #8467

merged 2 commits into from Sep 28, 2021

Conversation

lidel
Copy link
Member

@lidel lidel commented Sep 28, 2021 •
edited

This PR aims to close #8330 and unblock 0.10.0-rc2

TODO

  • add github action workflow and reuse bin/push-docker-tags.sh (so we get same image names)
  • set up docker hub secrets for publishing (DOCKER_USERNAME & DOCKER_PASSWORD)
    • using temporary credentials for testing, need to switch to ones from ipfsbot but we can do that later this week
  • remove docker publishing from circleci scripts

@lidel lidel force-pushed the chore/docker-images-via-github branch from 2d84a7e to 23ecce5 Compare September 28, 2021 20:19
@lidel lidel marked this pull request as ready for review September 28, 2021 20:20
@lidel lidel merged commit c0f282f into master Sep 28, 2021
@lidel lidel deleted the chore/docker-images-via-github branch September 28, 2021 20:30
@lidel lidel mentioned this pull request Sep 28, 2021
Closed
@olizilla
Copy link
Member

Bellissimo!

aschmahmann pushed a commit that referenced this pull request Sep 30, 2021
@lidel @aschmahmann
ci: move Docker image build to Actions (#8467)
4822023 
* ci: move docker image publishing to github

Closes #8330

* chore: remove dockerhub push from circleci

(cherry picked from commit c0f282f)
@aschmahmann aschmahmann mentioned this pull request Sep 30, 2021
Merged
@aschmahmann aschmahmann mentioned this pull request Dec 1, 2021
Closed
80 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guseggert guseggert guseggert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move Docker build to Actions
3 participants
@lidel @olizilla @guseggert