Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update test/dependencies to match actual go-ipfs dependencies. #8928

Merged
merged 8 commits into from
May 4, 2022

Conversation

ajnavarro
Copy link
Member

@ajnavarro ajnavarro commented May 3, 2022

This PR intends to match go-ipfs dependencies with test/dependencies dependencies.

  • Update go version from 1.13 to 1.17
  • Update dependencies using go get github.com/ipfs/go-ipfs@latest && go mod edit -droprequire github.com/ipfs/go-ipfs && go mod tidy
  • Refactor code to make it works with new dependency changes

Still work to do. I don't have enough knowledge to know if we can safely delete storeutil.StorerForBlockstore(bs) from graphsync-get.go

Closes #8310

Signed-off-by: Antonio Navarro Perez antnavper@gmail.com

@welcome
Copy link

welcome bot commented May 3, 2022

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@@ -1,30 +1,244 @@
module github.com/ipfs/go-ipfs/test/dependencies

go 1.13
go 1.17

require (
github.com/Kubuxu/gocovmerge v0.0.0-20161216165753-7ecaa51963cd
github.com/golangci/golangci-lint v1.26.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update golangci-lint as well

go.mod Outdated Show resolved Hide resolved
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
Done to avoid dependency inconsistency problems.

Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
@ajnavarro ajnavarro marked this pull request as ready for review May 4, 2022 15:07
Copy link
Contributor

@aschmahmann aschmahmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks 🙏

@aschmahmann aschmahmann merged commit 0f8a1a3 into ipfs:master May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dependencies of test/dependencies/go.mod
2 participants