Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconcile EnumerateChildrenAsync with EnumerateChildren #40

Closed
Stebalien opened this issue Jul 11, 2019 · 2 comments
Closed

Reconcile EnumerateChildrenAsync with EnumerateChildren #40

Stebalien opened this issue Jul 11, 2019 · 2 comments
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@Stebalien
Copy link
Member

EnumerateChildrenAsync visits the root node, EnumerateChildren doesn't. This is probably causing several subtle bugs but fixing it could cause other subtle bugs.
@Stebalien Stebalien added the kind/bug A bug in existing code (including security flaws) label Jul 11, 2019
@MichaelMure
Copy link
Contributor

Addressed in #42

@MichaelMure
Copy link
Contributor

This can be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MichaelMure @Stebalien