fix: do not append peer ids to provider multiaddrs #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a routing returns a set of multiaddrs, honour them as returned instead of appending the peer id to them.
5 tasks
2color
reviewed
Apr 23, 2024
| return ma | ||
| } | ||
|
|
||
| return ma.encapsulate(`/p2p/${peer.id}`) |
There was a problem hiding this comment.
Why were we doing this in the first place?
There was a problem hiding this comment.
Good question, I don't think it's necessary since we only care when we try to dial a multiaddr, and libp2p appends it if it's not there at that point.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a routing returns a set of multiaddrs, honour them as returned instead of appending the peer id to them.
Change checklist