This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
Pubsub message fields #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 14, 2017
|
@diasdavid Needs PR libp2p/js-libp2p-floodsub#49 released. Then update dependencies. |
daviddias
reviewed
Nov 15, 2017
| @@ -122,7 +122,7 @@ module.exports = (common) => { | |||
| expect(msg.data.toString()).to.equal('hi') | |||
| expect(msg).to.have.property('seqno') | |||
| expect(Buffer.isBuffer(msg.seqno)).to.be.eql(true) | |||
| expect(msg).to.have.property('topicCIDs').eql([topic]) | |||
| expect(msg).to.have.property('topicIDs').eql([topic]) | |||
There was a problem hiding this comment.
This means that js-ipfs-api is also incorrect. Mind checking that?
There was a problem hiding this comment.
Good call, already fixed in ipfs-inactive/js-ipfs-http-client#627
|
@diasdavid have you updated dependency to new the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename to topicCIDs should be topicIDs. See the background discussion.