This repository has been archived by the owner on Jun 27, 2023. It is now read-only.
Published message field names #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
daviddias
reviewed
Nov 14, 2017
| @@ -131,7 +131,7 @@ describe('basics between 2 nodes', () => { | |||
| expect(msg.data.toString()).to.equal('banana') | |||
| expect(msg.from).to.be.eql(fsB.libp2p.peerInfo.id.toB58String()) | |||
| expect(Buffer.isBuffer(msg.seqno)).to.be.true() | |||
| expect(msg.topicCIDs).to.be.eql(['Z']) | |||
| expect(msg.topicIDs).to.be.eql(['Z']) | |||
There was a problem hiding this comment.
The protobuf also needs to be updated https://github.com/libp2p/js-libp2p-floodsub/blob/master/src/message/rpc.proto.js
There was a problem hiding this comment.
This was referenced Nov 14, 2017
|
LGTM |
richardschneider
added a commit
that referenced
this pull request
Nov 19, 2017
This reverts commit b8f66cd.
Merged
daviddias
pushed a commit
that referenced
this pull request
Nov 22, 2017
* fix: startup * Revert "fix: Published message field names (#49)" This reverts commit b8f66cd. * fix: close should always invoke callback * fix: avoid race conditions, by quietly ignoring unsub when shutdown * fix: only delete peer when connections match * fix: lint errors * fix: more work on connection shutdown * fix: RPC msg.from is now binary * fix: lint errors * fix: multiple connections to/from same peer This implements a refernce counting scheme. See #51 (comment) One test is still failing. * fix: topicCIDs => topicIDs * test: can not get this test to work! * fix: lint errors * fix: review changes * fix: lint errors on a comment, this going too far * test: get test working * test: add tests for publishing an array of messages * subscribe: polling for connectivity replaced by handling peer connection event * fix typo
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JS implementation has renamed the field
topicIDstotopicCIDs, see the Message spec. This is not a good idea. See background discussion