Skip to content
This repository has been archived by the owner on Aug 1, 2023. It is now read-only.

feat: add kubo-rpc-client #499

Merged
merged 12 commits into from Oct 6, 2022
Merged

feat: add kubo-rpc-client #499

merged 12 commits into from Oct 6, 2022

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Sep 19, 2022 •
edited

SgtPooki
SgtPooki commented Sep 19, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
@SgtPooki
Copy link
Member Author

Currently getting an error on js-rv1-js circuit test. see attached log from running DEBUG='ipfs*,libp2p*' GOLOG_LOG_LEVEL='debug,core/server=debug' npm run test -- -g 'js-rv1-js' -d &> js-rv1-js.log
js-rv1-js.log

@SgtPooki SgtPooki added status/blocked Unable to be worked further until needs are met need/maintainers-input Needs input from the current maintainer(s) labels Sep 21, 2022
@SgtPooki SgtPooki changed the title feat: add kubo-rpc-client [WIP] feat: add kubo-rpc-client Sep 21, 2022
@SgtPooki SgtPooki marked this pull request as ready for review September 21, 2022 22:41
SgtPooki
SgtPooki commented Sep 23, 2022
View reviewed changes
Copy link
Member Author

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self review

@SgtPooki SgtPooki mentioned this pull request Sep 23, 2022
Merged
SgtPooki
SgtPooki commented Sep 23, 2022
View reviewed changes
Copy link
Member Author

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self review

SgtPooki
SgtPooki commented Sep 23, 2022
View reviewed changes
package.json Outdated
@@ -181,7 +181,7 @@
"import-meta-resolve": "^2.0.3",
"ipfs-unixfs": "^7.0.0",
"ipfs-utils": "^9.0.1",
"ipfsd-ctl": "^12.0.0",
"ipfsd-ctl": "https://gitpkg.now.sh/SgtPooki/js-ipfsd-ctl?feature/add-js-kubo-rpc-client&scripts.postinstall=npm%20install%20--ignore-scripts%20%26%26%20npm%20run%20build",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will replace with proper version when ipfs/js-ipfsd-ctl#764 is merged and published.

@SgtPooki
Copy link
Member Author

Updated package-lock.json so npm install stops failing: https://github.com/ipfs/interop/actions/runs/3114818422/jobs/5112612445

@SgtPooki SgtPooki changed the title [WIP] feat: add kubo-rpc-client feat: add kubo-rpc-client Sep 28, 2022
@BigLep
Copy link

BigLep commented Sep 30, 2022

@SgtPooki : we can remove the "status/blocked" label right?

@achingbrain : given CI is green, is it ok to merge?

@achingbrain
Copy link
Member

ipfs/js-ipfsd-ctl#764 needs to land first, then all good here.

@SgtPooki
Copy link
Member Author

SgtPooki commented Oct 5, 2022

Should be able to update this with the newest version once js-ipfsd-ctl releases: https://github.com/ipfs/js-ipfsd-ctl/actions/runs/3192111210

@SgtPooki
Copy link
Member Author

SgtPooki commented Oct 5, 2022

version 12.12.0 is pushed to npm: https://www.npmjs.com/package/ipfsd-ctl

@BigLep
Copy link

BigLep commented Oct 6, 2022

@SgtPooki : given CI is passing, are we ok to merge?

@SgtPooki SgtPooki merged commit d710daa into master Oct 6, 2022
@SgtPooki SgtPooki deleted the feat/add-kubo-rpc-client branch October 6, 2022 17:29
github-actions bot pushed a commit that referenced this pull request Oct 6, 2022
@semantic-release-bot
chore(release): 9.1.0 [skip ci]
294d53d 
## [9.1.0](v9.0.3...v9.1.0) (2022-10-06)

### Features

* add kubo-rpc-client ([#499](#499)) ([d710daa](d710daa))
@github-actions
Copy link

github-actions bot commented Oct 6, 2022

🎉 This PR is included in version 9.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lidel lidel Awaiting requested review from lidel

@achingbrain achingbrain Awaiting requested review from achingbrain

Assignees
No one assigned
Labels
need/maintainers-input Needs input from the current maintainer(s) released status/blocked Unable to be worked further until needs are met
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use kuboRpcModule instead of ipfsHttpModule in ipfs/interop
3 participants
@SgtPooki @BigLep @achingbrain