Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile has typo (ipfs-cluster-ctl and ipfs-cluster-service are same binaries) #194

Closed
mikhail-manuilov opened this issue Oct 25, 2017 · 1 comment
Closed

Dockerfile has typo (ipfs-cluster-ctl and ipfs-cluster-service are same binaries) #194

mikhail-manuilov opened this issue Oct 25, 2017 · 1 comment
Assignees
@hsanjuan
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@mikhail-manuilov
Copy link

mikhail-manuilov commented Oct 25, 2017 •
edited
Loading

Dockerfile has typo (ipfs-cluster-ctl and ipfs-cluster-service are same binaries)

/ # ls -al `which ipfs-cluster-ctl `
-rwxr-xr-x    1 root     root      24663755 Oct 23 18:18 /usr/local/bin/ipfs-cluster-ctl
/ # ls -al `which ipfs-cluster-service `
-rwxr-xr-x    1 root     root      24663755 Oct 23 18:18 /usr/local/bin/ipfs-cluster-service

From Dockerfile:

COPY --from=builder $GOPATH/bin/ipfs-cluster-service /usr/local/bin/ipfs-cluster-service
COPY --from=builder $GOPATH/bin/**ipfs-cluster-service** /usr/local/bin/**ipfs-cluster-ctl**
hsanjuan added a commit that referenced this issue Oct 25, 2017
@hsanjuan
Merge pull request #196 from ipfs/fix/194-same-binary
f002dd1 
Fix #194: Same binary in dockerfile
@hsanjuan
Copy link
Collaborator

Thanks, the :lastest should be rebuilt now with the fix

@hsanjuan hsanjuan added the kind/bug A bug in existing code (including security flaws) label Oct 25, 2017
@hsanjuan hsanjuan self-assigned this Oct 25, 2017
@hsanjuan hsanjuan added this to the User feedback and bugs [Q4O3] milestone Oct 25, 2017
@hsanjuan hsanjuan mentioned this issue Oct 26, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hsanjuan hsanjuan

Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hsanjuan @mikhail-manuilov