cmd/svc/lock: check config dir and file existence #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There were the following issues with your Pull Request
Guidelines are available at https://github.com/ipfs/ipfs-cluster/blob/master/contribute.md This message was auto-generated by https://gitcop.com |
ghost
assigned 
License: MIT Signed-off-by: Adrian Lanzafame <adrianlanzafame92@gmail.com>
lanzafame
force-pushed
the
fix/svc/init/lock
branch
from
26d40d2
to
271c743
Compare
hsanjuan
reviewed
Apr 4, 2018
|
|
||
| func (l *lock) checkConfigExists() error { | ||
| if _, err := os.Stat(l.path); os.IsNotExist(err) { | ||
| logger.Error("ipfs-cluster-service config hasn't been initialized.\nPlease run ipfs-cluster-service init") |
There was a problem hiding this comment.
I don't know if I'm 100% behind line breaks in a log message (considering we don't worry about line length anywhere). Any arguments to support it?
There was a problem hiding this comment.
Not running ipfs-cluster-service init is a common newcomer error (aka me 😛 ) and so making it more readable was the thought behind it. Happy to take it out.
hsanjuan
approved these changes
Apr 5, 2018
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #343.