Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ipfs-cluster-service and ipfs-cluster-ctl to cmd/ #485

Closed
4 of 9 tasks
lanzafame opened this issue Jun 29, 2018 · 2 comments
Closed
4 of 9 tasks

Move ipfs-cluster-service and ipfs-cluster-ctl to cmd/ #485

lanzafame opened this issue Jun 29, 2018 · 2 comments
Assignees
@kishansagathiya
Labels
exp/novice Someone with a little familiarity can pick up P3 Low: Not priority right now

Comments

@lanzafame
Copy link
Contributor

Basic information

  • Version information (mark as appropiate):
    • Master
    • Release candidate for next version
    • Latest stable version
    • An older version I should not be using
  • Type (mark as appropiate):
    • Bug
    • Feature request
    • Enhancement

Description

Move ipfs-cluster-service and ipfs-cluster-ctl to cmd/ directory to follow "standard" project structure.
@hsanjuan hsanjuan added help wanted Seeking public contribution on this issue exp/novice Someone with a little familiarity can pick up status/ready Ready to be worked P3 Low: Not priority right now labels Jun 29, 2018
kishansagathiya added a commit to kishansagathiya/ipfs-cluster that referenced this issue Aug 26, 2018
@kishansagathiya
Move ipfs-cluster-service and ipfs-cluster-ctl to cmd/
1e67941 
This commit moves `ipfs-cluster-service` and `ipfs-cluster-ctl` to
`cmd/` directory to follow "standard" project structure.

Fixes ipfs-cluster#485

License: MIT
Signed-off-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
@kishansagathiya kishansagathiya mentioned this issue Aug 26, 2018
Closed
kishansagathiya added a commit to kishansagathiya/ipfs-cluster that referenced this issue Aug 26, 2018
@kishansagathiya
Move ipfs-cluster-service and ipfs-cluster-ctl to cmd/
37969a1 
This commit moves `ipfs-cluster-service` and `ipfs-cluster-ctl` to
`cmd/` directory to follow "standard" project structure.

Fixes ipfs-cluster#485

License: MIT
Signed-off-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
@kishansagathiya
Copy link
Contributor

kishansagathiya commented Aug 26, 2018 •
edited
Loading

I have tried to attempt this issue with #521. Plz review whenever you find time.

kishansagathiya added a commit to kishansagathiya/ipfs-cluster that referenced this issue Aug 27, 2018
@kishansagathiya
Move ipfs-cluster-service and ipfs-cluster-ctl to cmd/
30cd26f 
This commit removes `ipfs-cluster-service` and `ipfs-cluster-ctl`
executable files and ignores them from git

Fixes ipfs-cluster#485

License: MIT
Signed-off-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
@hsanjuan hsanjuan mentioned this issue Aug 27, 2018
Closed
@hsanjuan hsanjuan added status/in-progress In progress and removed help wanted Seeking public contribution on this issue status/ready Ready to be worked labels Aug 29, 2018
@hsanjuan
Copy link
Collaborator

Fixed by #521 #556

@ghost ghost removed the status/in-progress In progress label Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kishansagathiya kishansagathiya

Labels
exp/novice Someone with a little familiarity can pick up P3 Low: Not priority right now
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hsanjuan @lanzafame @kishansagathiya