Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster graph command should distinguish between trusted and untrusted peers #800

Closed
lanzafame opened this issue May 28, 2019 · 7 comments · Fixed by #925
Closed

Cluster graph command should distinguish between trusted and untrusted peers #800

lanzafame opened this issue May 28, 2019 · 7 comments · Fixed by #925
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P3 Low: Not priority right now status/ready Ready to be worked

Comments

@lanzafame
Copy link
Contributor

Describe the feature you are proposing

The output of ipfs-cluster-ctl health graph should distinguish between which peers are in the trusted peerset and which are not.

@lanzafame lanzafame added kind/enhancement A net-new feature or improvement to an existing feature need/review Needs a review labels May 28, 2019
@hsanjuan hsanjuan added exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue status/ready Ready to be worked and removed need/review Needs a review labels Jun 10, 2019
@hsanjuan hsanjuan added the P3 Low: Not priority right now label Jul 23, 2019
@kishansagathiya
Copy link
Contributor

Do you mean that it should show which peers which are trusted by us and which are not?

@hsanjuan
Copy link
Collaborator

Yes, by coloring them differently for example.

@kishansagathiya
Copy link
Contributor

I think showing the peers which are trusted/untrusted by local peers should be enough. We don't need to show trust links between any other peers.

@hsanjuan
Copy link
Collaborator

hsanjuan commented Sep 6, 2019

I think showing the peers which are trusted/untrusted by local peers should be enough. We don't need to show trust links between any other peers.

Correct. You get a PNG and it shows trusted peers in green and untrusted in red (for example)

@kishansagathiya
Copy link
Contributor

Something like this
Black for self
Green for trusted
Blue for untrusted
Golden for IPFS
xyz

@hsanjuan
Copy link
Collaborator

Yes, can you now prettify labels? Research if there is a way to include a legend about the colors? See if there is a way to "group" a cluster peer with it's ipfs daemon inside a box or something?

@kishansagathiya
Copy link
Contributor

I am planning these changes

  • cluster nodes solid and IPFS hollow,
  • trusted node dark green and untrusted light green
  • Instead of using labels like <peer.ID Qm*IrV9Se>, use last five characters
  • for out own node use Self as label

From what I have read, you can't create box around two nodes. You can group them together, but that only makes sure that the arrow between two nodes is straight. It would look like this
what

But using subgraphs and using rank attribute for that subgraph makes thing quite prettier
what

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P3 Low: Not priority right now status/ready Ready to be worked
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants