Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MV3 Beta Bug] Redirect infinite loop with Brave when hitting "purple IPFS button" #1283

Closed
BigLep opened this issue Sep 18, 2023 · 4 comments · Fixed by #1285
Closed

[MV3 Beta Bug] Redirect infinite loop with Brave when hitting "purple IPFS button" #1283

BigLep opened this issue Sep 18, 2023 · 4 comments · Fixed by #1285
Assignees
Labels
area/MV3 Issues related to Manifest V3 version kind/bug A bug in existing code (including security flaws) mv3-beta-bugs

Comments

@BigLep
Copy link
Contributor

BigLep commented Sep 18, 2023

Describe the bug
I can get Brave into a redirect loop

To Reproduce
Steps to reproduce the behavior:

  1. Use external Kubo node (e.g., IPFS Desktop)
  2. Clear all redirect rules.
  3. Go to https://explore.ipld.io
  4. Browser bar becomes http://explore.ipld.io.ipns.localhost:8080/
  5. Hit purpose "IPFS" button in address bar
  6. Browser redirects to https://explore-ipld-io.ipns.dweb.link/ but white screen
image 8. Refresh redirects to http://explore.ipld.io.ipns.localhost:8080/ 9. After that I can't reproduce it. It seems to be a first-time issue. I have to clear redirect rules to trigger this again.

Versions

  • Companion 3.0.0.1131
  • Brave 1.57.47 Chromium: 116.0.5845.96 (Official Build) (arm64)
@BigLep BigLep added kind/bug A bug in existing code (including security flaws) area/MV3 Issues related to Manifest V3 version mv3-beta-bugs labels Sep 18, 2023
@whizzzkid
Copy link
Contributor

@BigLep on step 6 you just see a white screen? Is the browser still redirecting? The purple button is shipped by brave, it has its own quirks. Since the purple button redirects to dweb.link instead of staying on what the current url is, companion is seeing this url for the first time. Once the URL is known and rule is added it should work from there. Maybe I can add a manual rule if it's brave.

@lidel
Copy link
Member

lidel commented Sep 20, 2023

@BigLep just for the record, what are your settings on brave://settings/ipfs, mainly resolution method? Gateway?

2023-09-20_18-19

@BigLep
Copy link
Contributor Author

BigLep commented Sep 20, 2023

Here's more info:

brave://settings/ipfs
image

Here's a screen recording:

Screen.Recording.2023-09-20.at.09.55.08.mov

@whizzzkid
Copy link
Contributor

@BigLep this is a very weird edge case, looks like since you have the Method to resolve IPFS resources set to Gateway, this interferes with companion behaviour. Because brave does not find the Gateway it believes public resolution is required to dweb.link, which gets observed by companion and back to localhost. it's a timing issue I believe, where dweb.link just takes long enough to not be redirected by companion's rule. Because if you directly try to go to https://dweb.link/ipns/explore.ipld.io/ it just resolves fine. It's if the double redirection, first from brave then from companion, which makes it hard. I'm looking into if I can reliably resolve the urls and then reload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/MV3 Issues related to Manifest V3 version kind/bug A bug in existing code (including security flaws) mv3-beta-bugs
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants