Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: apple notarization of ipfs-desktop binary #2623

Closed
SgtPooki opened this issue Sep 12, 2023 · 1 comment · Fixed by #2624
Closed

fix: apple notarization of ipfs-desktop binary #2623

SgtPooki opened this issue Sep 12, 2023 · 1 comment · Fixed by #2624
Assignees
@SgtPooki
Labels
kind/bug A bug in existing code (including security flaws) need/maintainers-input Needs input from the current maintainer(s) P0 Critical: Tackled by core team ASAP status/in-progress In progress topic/ci Continuous integration topic/infra Infrastructure

Comments

@SgtPooki
Copy link
Member

SgtPooki commented Sep 12, 2023 •
edited by lidel

cc #1753

apple notarization is currently failing (see failing CI for #2621)

we have a PL apple developer account (as mentioned here), but I don't believe we're currently using that one for ipfs-desktop.

Either way, I don't have access to the one-password account that we're currently using for notarization.

I reached out to Andy to try and get us unblocked.
@SgtPooki SgtPooki added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization labels Sep 12, 2023
@SgtPooki SgtPooki mentioned this issue Sep 12, 2023
Merged
@SgtPooki SgtPooki added status/in-progress In progress P0 Critical: Tackled by core team ASAP need/maintainers-input Needs input from the current maintainer(s) topic/ci Continuous integration topic/infra Infrastructure and removed need/triage Needs initial labeling and prioritization labels Sep 12, 2023
@SgtPooki SgtPooki self-assigned this Sep 12, 2023
@SgtPooki
Copy link
Member Author

Seems like a new contract needed signed (by Wayne). It was signed and the CI seems to be succeeding now: https://github.com/ipfs/ipfs-desktop/actions/runs/6151308066/job/16727491264

Also, the failed warning indicates we will start having problems in a few months without some updates:

Warning: altool has been deprecated for notarization and starting in late 2023 will no longer be supported by the Apple notary service. You should start using notarytool to notarize your software.

From electron/notarize#137 (comment), it seems like updating the call to notarize with:

{
    //...
    tool: 'notarytool',
    teamId: '7Y229E2YRL' // team ID confirmed with Wayne and seems to be output here: https://github.com/ipfs/ipfs-desktop/actions/runs/6151308066/job/16727491264#step:12:67
}

should be all we need.

@SgtPooki SgtPooki linked a pull request Sep 12, 2023 that will close this issue
fix(apple-notarize): use notarytool and teamId #2624
Merged
@SgtPooki SgtPooki mentioned this issue Sep 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SgtPooki SgtPooki

Labels
kind/bug A bug in existing code (including security flaws) need/maintainers-input Needs input from the current maintainer(s) P0 Critical: Tackled by core team ASAP status/in-progress In progress topic/ci Continuous integration topic/infra Infrastructure
Projects
No open projects
IPFS-GUI (PL EngRes)
Status: Needs Grooming
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(apple-notarize): use notarytool and teamId ipfs/ipfs-desktop
1 participant
@SgtPooki