Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix submenu to expand when visiting page directly. #274

Closed
andrew opened this issue Jan 21, 2020 · 3 comments
Closed

Fix submenu to expand when visiting page directly. #274

andrew opened this issue Jan 21, 2020 · 3 comments
Assignees
Labels
dif/hard Having worked on the specific codebase is important effort/days Estimated to take multiple days, but less than a week kind/enhancement A net-new feature or an improvement to an existing feature P3 Low: Not priority right now status/inactive No significant work in the previous month topic/design-front-end Front-end implementation of UX/UI work

Comments

@andrew
Copy link
Contributor

andrew commented Jan 21, 2020

When directly visiting a top level section (like Community) on the new docs beta (i.e. clicking from offsite or pasting https://docs-beta.ipfs.io/community/ directly into your address bar), the left hand menu doesn't expand for the highlighted section:

Screenshot 2020-01-21 at 14 07 29

I would expect it to be expanded in the same was as if I clicked on the "Community" link in the menu:

Screenshot 2020-01-21 at 14 08 20

I happens for all the top level sections, not just Community, but it does work as expected for sub-sections like Community >> IRC

@cwaring
Copy link
Member

cwaring commented Jan 21, 2020

Good catch, I'll try to patch this up in the next round of menu refactors!

@cwaring cwaring self-assigned this Jan 21, 2020
@jessicaschilling
Copy link
Contributor

Also for context, see https://github.com/ipfs/docs/issues/389 -- we'll be making future changes to the nav overall that, while they don't address what you've brought up in this issue, do speak to overall nav evolution. Ideally we'd get this submenu concern addressed either before, or in parallel, with the work that closes #265.

@johnnymatthews johnnymatthews changed the title [Beta bug] Left-hand submenu doesn't expand when visiting a top level section directly Left-hand submenu doesn't expand when visiting a top level section directly. Jan 27, 2020
@hsanjuan hsanjuan transferred this issue from ipfs-inactive/docs May 22, 2020
@johnnymatthews johnnymatthews added the need/triage Needs initial labeling and prioritization label Jun 6, 2020
@johnnymatthews
Copy link
Contributor

Just tried this on the VuePress docs site and it doesn't seem to be an issue there, so this is likely something that we've changed.

@johnnymatthews johnnymatthews changed the title Left-hand submenu doesn't expand when visiting a top level section directly. Fix submenu to expand when visiting page directly. Jun 17, 2020
@johnnymatthews johnnymatthews added dif/hard Having worked on the specific codebase is important effort/days Estimated to take multiple days, but less than a week kind/enhancement A net-new feature or an improvement to an existing feature P3 Low: Not priority right now status/inactive No significant work in the previous month topic/design-front-end Front-end implementation of UX/UI work and removed need/triage Needs initial labeling and prioritization labels Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dif/hard Having worked on the specific codebase is important effort/days Estimated to take multiple days, but less than a week kind/enhancement A net-new feature or an improvement to an existing feature P3 Low: Not priority right now status/inactive No significant work in the previous month topic/design-front-end Front-end implementation of UX/UI work
Projects
None yet
Development

No branches or pull requests

4 participants