Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch publish-release-build.yml to CAR #1847

Closed
aptalca opened this issue Sep 6, 2021 · 4 comments
Closed

Switch publish-release-build.yml to CAR #1847

aptalca opened this issue Sep 6, 2021 · 4 comments
Labels
exp/intermediate Prior experience is likely helpful help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) kind/maintenance Work required to avoid breaking changes or harm to project's status quo P2 Medium: Good to have, but can wait until someone steps up

Comments

@aptalca
Copy link

aptalca commented Sep 6, 2021 •
edited

Describe the bug
Just a heads up (in case you haven't noticed already), the GitHub actions for the ci have been failing for the last few commits (js test) and the release binary upload action also failed in this repo.
@aptalca aptalca added the need/triage Needs initial labeling and prioritization label Sep 6, 2021
@ipfs ipfs deleted a comment from welcome bot Sep 10, 2021
@lidel lidel changed the title Ci tests failing, no tarball added to release TAR missing from the latest release notes Sep 10, 2021
@lidel
Copy link
Member

lidel commented Sep 10, 2021 •
edited

Thanks for raising this.

Fixing E2E tests against js-ipfs is already tracked in #1737

The job that attaches binaries failed due to unrelated reasons.

I believe we should rewrite it to read the latest release via github api (either dedicated action or https://api.github.com/repos/ipfs/ipfs-webui/releases/latest) and then generate TAR and CAR by fetching the CID listed in Release notes.

I won't have bandwidth to do this any time soon, but PR welcome.

@lidel lidel added exp/intermediate Prior experience is likely helpful help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) kind/maintenance Work required to avoid breaking changes or harm to project's status quo P2 Medium: Good to have, but can wait until someone steps up and removed need/triage Needs initial labeling and prioritization labels Sep 10, 2021
@aptalca
Copy link
Author

aptalca commented Sep 19, 2021

Looks like the tar file was created successfully, but the upload failed. Can you rerun that action from the github gui?

@lidel
Copy link
Member

lidel commented Feb 2, 2022

  • The TAR failed to upload today again – lacks a robust retry
  • Ideally, we would remove TAR and only use verifiable CAR
  • For now, attached both manually to v2.14.0 (but we may gzip CAR when we automate this)

@lidel lidel changed the title TAR missing from the latest release notes Switch publish-release-build.yml to CAR Feb 2, 2022
@SgtPooki
Copy link
Member

I believe this should be resolved now as all our releases contain a CAR file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exp/intermediate Prior experience is likely helpful help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) kind/maintenance Work required to avoid breaking changes or harm to project's status quo P2 Medium: Good to have, but can wait until someone steps up
Projects
No open projects
IPFS-GUI (PL EngRes)
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lidel @aptalca @SgtPooki