Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: missing protocol breaks the peers page #878

Closed
jbenet opened this issue Nov 3, 2018 · 5 comments
Closed

Bug: missing protocol breaks the peers page #878

jbenet opened this issue Nov 3, 2018 · 5 comments
Labels
kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP

Comments

@jbenet
Copy link
Member

jbenet commented Nov 3, 2018

Missing protocol (quic) breaks execution in the peers page, and causes it all to fail.

may want to:

  • add quic (known protocol) to codec.js
  • isolate failures (one failing protocol shouldnt break everything. assume protocols may exist that are not yet registered in the codec.js table)
  • level up codec.js to deal with or admit unknown protocols.
protocols-table.js:17 Uncaught Error: no protocol with name: quic
    at i (protocols-table.js:17)
    at u (codec.js:45)
    at y (codec.js:170)
    at Object.fromString (codec.js:178)
    at o.l.proto.className (index.js:43)
    at new Multiaddr (index.js:40)
    at l.proto.className (index.js:26)
    at Multiaddr (index.js:40)
    at t.Strings.r.map.e (peers.js:48)
    at Array.map (<anonymous>)

image

@lidel lidel added kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP labels Nov 4, 2018
@olizilla
Copy link
Member

olizilla commented Nov 5, 2018

I think webui has handled this as gracefully as it can, the call to ipfsApi.swarm.peers() has thrown and uncaught error, so webui recieves no information to about the current peers list.

js-ipfs-api needs to handle multiaddr errors when unpacking the the api response. I'll issue and PR that.

@lidel lidel added P2 Medium: Good to have, but can wait until someone steps up and removed P0 Critical: Tackled by core team ASAP labels Nov 5, 2018
@olizilla olizilla added P0 Critical: Tackled by core team ASAP and removed P2 Medium: Good to have, but can wait until someone steps up labels Nov 5, 2018
@olizilla
Copy link
Member

olizilla commented Nov 5, 2018

Issue for how to handle unvalidatable peers in the js-ipfs-api client ipfs-inactive/js-ipfs-http-client#885

@lidel
Copy link
Member

lidel commented Nov 6, 2018

Quick update for drive-by visitors:

  • js-multiaddr v5.0.2 shipped with the fix, needs to be bumped in all libs that use it
  • ipfs-companion v2.5.1.12010 (beta) applies the above fix when bundled ipfs-webui is used

@olizilla
Copy link
Member

olizilla commented Nov 8, 2018

There is a PR to make js-ipfs-api robust to peer validation errors ipfs-inactive/js-ipfs-http-client#887

and also of note there is an open issue to get multiaddr to support unverifiable addresses multiformats/multiaddr#70

@olizilla
Copy link
Member

This was fixed in ipfs-inactive/js-ipfs-http-client#887 and #884

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP
Projects
None yet
Development

No branches or pull requests

3 participants