Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shrink the peers map to fit the screen #903

Closed
anacrolix opened this issue Dec 11, 2018 · 1 comment · Fixed by #906
Closed

Shrink the peers map to fit the screen #903

anacrolix opened this issue Dec 11, 2018 · 1 comment · Fixed by #906
Assignees
Labels
exp/intermediate Prior experience is likely helpful kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up

Comments

@anacrolix
Copy link

The map in the peers tab doesn't shrink to fit the screen, so on small screens one only sees Europe and West Africa. Even on a typically large screen, Alaska, and East Asia may be missing.

@olizilla olizilla added kind/bug A bug in existing code (including security flaws) exp/intermediate Prior experience is likely helpful labels Dec 12, 2018
@olizilla
Copy link
Member

Thanks, this is on my radar. The first implemenation of this was reponsive, but it relied on d3 redrawing the world map from json data bout land boundaries on every update, which was, unsuprisingly, taxing on system resources.

In optimising it I ended up capturing the rendered world map to a static svg, and then overlaying the points via d3. That was much lighter, but in doing so I've decoupled the positioning of the dots with whe underlying map. The svg will scale nicely, but both the d3 layer and the svg need to scale proportionally to ensure the points remain in the right locations. It'll either be trivial to fix or really fiddly.

@olizilla olizilla added the P2 Medium: Good to have, but can wait until someone steps up label Dec 12, 2018
@ghost ghost assigned olizilla Dec 13, 2018
@ghost ghost added the status/in-progress In progress label Dec 13, 2018
@ghost ghost removed the status/in-progress In progress label Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/intermediate Prior experience is likely helpful kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants