Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

Error: Cannot find module 'bl' #275

Closed
Mithgol opened this issue May 17, 2016 · 8 comments · Fixed by #276
Closed

Error: Cannot find module 'bl' #275

Mithgol opened this issue May 17, 2016 · 8 comments · Fixed by #276

Comments

@Mithgol
Copy link
Contributor

Mithgol commented May 17, 2016

The line const bl = require('bl') (added to src/api/object.js in 2000d22) seems to cause an error because the package bl is not listed in the module's dependencies.

(screenshot)

@dignifiedquire
Copy link
Contributor

Yes looks like it's missing from the devDependencies

@Mithgol
Copy link
Contributor Author

Mithgol commented May 17, 2016

Wait, why devDependencies and not dependencies?

@daviddias
Copy link
Contributor

@Mithgol you are right, it should be on dependencies. Mind making a PR?

In the other hand, you are running IPFS and using the JS libs on Windows? That is awesome! How has been the experience so far?

@dignifiedquire
Copy link
Contributor

my mistake, I misread the diff and thought it was inside a test

@Mithgol
Copy link
Contributor Author

Mithgol commented May 17, 2016

A pull request (#276) is made.

@Mithgol
Copy link
Contributor Author

Mithgol commented May 17, 2016

@diasdavid Yes, I'm running IPFS and using this JS API on Windows. Generally everything's fine there unless a minor issue surfaces such as this one or ipfs/kubo#2642.

daviddias added a commit that referenced this issue May 17, 2016
require `bl` version `^1.1.2` in order to fix #275
@daviddias
Copy link
Contributor

released 4.0.3 :)

@Mithgol
Copy link
Contributor Author

Mithgol commented May 17, 2016

After a bit of testing I can confirm that the above mentioned error is indeed eliminated in the version 4.0.3.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants