Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconsider the MessageQueue per peer approach #88

Closed
daviddias opened this issue Dec 21, 2016 · 2 comments
Closed

Reconsider the MessageQueue per peer approach #88

daviddias opened this issue Dec 21, 2016 · 2 comments
Labels
kind/enhancement A net-new feature or improvement to an existing feature kind/support A question or request for support P0 Critical: Tackled by core team ASAP status/ready Ready to be worked
Projects
ipfs/js-ipfs ipfs/js-waffle

Comments

@daviddias
Copy link
Member

As asked here: #76

Is a MessageQueue per peer the best approach? Why not piggyback on want list updates and just check what the peer wants and attach the blocks necessary?

It might be tad expensive to have a message queue for each peer, especially with a lot of Peer Churn
@daviddias daviddias added kind/enhancement A net-new feature or improvement to an existing feature kind/support A question or request for support labels Dec 21, 2016
@daviddias daviddias mentioned this issue Dec 21, 2016
Closed
15 tasks
@dignifiedquire
Copy link
Member

After the perf PR it is not a queue anymore, simply a buffer to combine message sending. I haven't found a good name for it yet though.

@daviddias
Copy link
Member Author

Interesting, need to read the new approach, didn't realise you applied it after I commented it out on the CID PR :)

@daviddias daviddias mentioned this issue Dec 21, 2016
Merged
@daviddias daviddias added the status/deferred Conscious decision to pause or backlog label Dec 22, 2016
@daviddias daviddias added status/ready Ready to be worked P0 Critical: Tackled by core team ASAP and removed status/deferred Conscious decision to pause or backlog status/ready Ready to be worked labels Oct 17, 2017
@momack2 momack2 added this to Ready in ipfs/js-ipfs May 10, 2019
@momack2 momack2 added this to Ready in ipfs/js-waffle May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement A net-new feature or improvement to an existing feature kind/support A question or request for support P0 Critical: Tackled by core team ASAP status/ready Ready to be worked
Projects
No open projects
ipfs/js-ipfs
Ready
ipfs/js-waffle
Ready
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dignifiedquire @daviddias