Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

jsipfs init creates a repo that is not compatible with go-ipfs #142

Closed
daviddias opened this issue Apr 12, 2016 · 10 comments
Closed

jsipfs init creates a repo that is not compatible with go-ipfs #142

daviddias opened this issue Apr 12, 2016 · 10 comments
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@daviddias
Copy link
Member

 ⭠ feature/swarm ⮀ ~/code/_ipfs/js/js-ipfs ⮀
» IPFS_PATH=~/.jsipfs jsipfs init
 ⭠ feature/swarm ⮀ ~/code/_ipfs/js/js-ipfs ⮀
» IPFS_PATH=~/.jsipfs ipfs daemon
Initializing daemon...
Error: no ipfs repo found in /Users/david/.jsipfs.
please run: ipfs init

I believe this is due go-ipfs does datastore (the LevelDB thing) checks, which we never implemented (since we didn't needed until we have the DHT going). Is there a way to create that folder eitherway so that a js-ipfs generated repo does work for a go-ipfs daemon? Simply dropping the same default datastore that go-ipfs generates should do the trick, not sure if there would be any concern there.

@noffle since you made js-ipfs init, would you like to look at this one? Thank you

@daviddias daviddias added the kind/bug A bug in existing code (including security flaws) label Apr 12, 2016
@hackergrrl
Copy link
Contributor

I already have a PR waiting for merge. :D ipfs/kubo#2497

@daviddias
Copy link
Member Author

Is it better to make the go-ipfs more loose? Or make js-ipfs more compliant? @whyrusleeping ?

@hackergrrl
Copy link
Contributor

Good Q. Is datastore mandatory for all IPFS repos?

@daviddias
Copy link
Member Author

@noffle if we had the DHT that go-ipfs implements, yes, it would be.

@whyrusleeping
Copy link
Member

making the go-ipfs daemon more loose on its requirements is good, but datastores are a mandatory thing, otherwise how will you store data?

(the 'datastore' directory itself is not required, as long as you have a datastore of some kind)

@daviddias
Copy link
Member Author

@whyrusleeping we have the datastore that stores blocks, not the datastore that stores DHT records (levelDB)

@whyrusleeping
Copy link
Member

theyre the same really, we just have a single datastore in go-ipfs. Its just a mounted datastore that stores certain key prefixes in one place and other key prefixes elsewhere.

I'm going to be changing the datastore config code soon, heres a preview of what our current setup looks like in that new format: https://gist.github.com/whyrusleeping/0252846bc655632449b1

@hackergrrl
Copy link
Contributor

So, it sounds like we're for looser reqs + non-mandatory datastore directory? If so, let's go ahead and get ipfs/kubo#2497 in.

@hackergrrl
Copy link
Contributor

Tested this with latest go-ipfs -- it works!

@daviddias
Copy link
Member Author

awesome! :D thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Development

No branches or pull requests

3 participants