This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: issue with isolateModules flag #3495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugomrdias
approved these changes
Jan 21, 2021
This was referenced Jan 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3494
It appears that
react-scriptsswapsisolateModuleswhich causes problems in webui because according to TS:Changes here address that problem as follows:
export type {...}is used as per TS error.isolateModulesflag is set totrueso that such issues can be caught locally.ipfs-client, so I had to add some type annotations to fix that.referencesinipfs-client/tsconfig.json, otherwise it does not pick up changes in the dependencies unless they are manually rebuild.