fix: update to new aegir #3528
fix: update to new aegir #3528
Conversation
hugomrdias
force-pushed
the
feat/update-to-new-aegir
branch
from
bdcbe71
to
df43c49
Compare
hugomrdias
force-pushed
the
feat/update-to-new-aegir
branch
from
df43c49
to
af55a9f
Compare
hugomrdias
force-pushed
the
feat/update-to-new-aegir
branch
from
03dd295
to
52f228b
Compare
todo: - [ ] ipfs-message-port-client needs: libp2p/js-libp2p-websockets#fix/esbuild-compat ipfs/aegir#feat/remove-webpack-karma
hugomrdias
force-pushed
the
feat/update-to-new-aegir
branch
from
0fbc9e5
to
e7c855a
Compare
.github/workflows/bundlesize.yml
Outdated
| - name: Bundlesize ${{ matrix.project }} | ||
| uses: ipfs/aegir/actions/bundle-size@v29.0.0 | ||
| uses: ipfs/aegir/actions/bundle-size@master |
There was a problem hiding this comment.
This should go back to being a version number
| const notAvailablePeerId = 'QmUmaEnH1uMmvckMZbh3yShaasvELPW4ZLPWnB4entMTEn' | ||
| const count = 2 | ||
|
|
||
| return expect(all(ipfsA.ping(notAvailablePeerId, { count }))).to.eventually.be.rejected() |
There was a problem hiding this comment.
i was trying to catch an uncaught rejection that happens sometimes, because the new runner fails when these happen now.
this seems to help a bit but 100%
| @@ -45,15 +45,14 @@ | |||
| "test:chrome": "aegir test -t browser -t webworker -- --browsers ChromeHeadless", | |||
| "test:firefox": "aegir test -t browser -t webworker -- --browsers FirefoxHeadless", | |||
| "lint": "aegir lint", | |||
| "prepare": "aegir build --no-bundle", | |||
There was a problem hiding this comment.
we dont need it here, the prepare for types is just to help with PR with gh url and mono-repo doesnt allow for gh url dep install. Plus it slows down everything
There was a problem hiding this comment.
mono-repo doesnt allow for gh url dep install
Good news! Now you can do:
$ npm install https://gitpkg.now.sh/ipfs/js-ipfs/packages/ipfs-core?some-branch-identifier| "coverage": "npx nyc -r html npm run test:node -- --bail", | ||
| "clean": "rimraf ./dist", | ||
| "dep-check": "aegir dep-check -i ipfs-core -i rimraf -i ipfs-core-types" | ||
| "dep-check": "aegir dep-check -i ipfs-core -i rimraf -i ipfs-core-types -i esbuild" |
There was a problem hiding this comment.
dep-check doesnt look into .aegir.js
|
The fs module prints out: in the browser console, needs to be overridden to |
https://github.com/ipfs-shipyard/js-mock-ipfs-pinning-service > https://github.com/isa-group/oas-tools/blob/master/package.json#L26 > https://github.com/npm/security-holder > open node_modules/fs/index.js 🤷🏻♂️ |
- update aegir - fix some linting - enable multiple test runs at the same time (all servers now try to find free ports) Co-authored-by: achingbrain <alex@achingbrain.net>
todo:
needs:
ipfs/interop#223